Home » Mailing list archives » linux-kernel » 2010 » March » 28

Re: [GIT, RFC] Killing the Big Kernel Lock

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Frederic Weisbecker
Subject: Re: [GIT, RFC] Killing the Big Kernel Lock
Date: Sunday, March 28, 2010 - 4:18 pm

On Wed, Mar 24, 2010 at 10:40:54PM +0100, Arnd Bergmann wrote:


About this one, there is a "sensible" part:


@@ -1943,7 +1949,7 @@ static ssize_t proc_fdinfo_read(struct file *file, char __user *buf,
 }
 
 static const struct file_operations proc_fdinfo_file_operations = {
-	.open		= nonseekable_open,
+	.llseek		= generic_file_llseek,
 	.read		= proc_fdinfo_read,
 };
 

Replacing default_llseek() by generic_file_llseek() as you
did for most of the other parts is fine.

But the above changes the semantics as it makes it seekable.
Why not just keeping it as is? It just ends up in no_llseek().

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: [GIT, RFC] Killing the Big Kernel Lock, Andrew Morton, (Wed Mar 24, 2:07 pm)
[GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Wed Mar 24, 2:40 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Roland Dreier, (Wed Mar 24, 2:53 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Wed Mar 24, 2:59 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Alan Cox, (Wed Mar 24, 3:10 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Ingo Molnar, (Wed Mar 24, 3:23 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Wed Mar 24, 3:25 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Thu Mar 25, 3:26 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, Jiri Kosina, (Thu Mar 25, 5:55 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Thu Mar 25, 6:06 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Thu Mar 25, 6:38 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, Dan Carpenter, (Thu Mar 25, 6:40 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Thu Mar 25, 7:14 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, Stefan Richter, (Fri Mar 26, 4:47 pm)
[PATCH] firewire: char device files are not seekable (BKL ..., Stefan Richter, (Sat Mar 27, 2:16 am)
[PATCH] ieee1394: char device files are not seekable (BKL ..., Stefan Richter, (Sat Mar 27, 2:20 am)
[PATCH RFC] DVB: add dvb_generic_nonseekable_open, dvb_gen ..., Stefan Richter, (Sat Mar 27, 3:40 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Sat Mar 27, 7:37 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, Stefan Richter, (Sun Mar 28, 5:27 am)
[PATCH RFC v2] DVB: add dvb_generic_nonseekable_open, dvb_ ..., Stefan Richter, (Sun Mar 28, 7:47 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, Frederic Weisbecker, (Sun Mar 28, 1:04 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Sun Mar 28, 1:05 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Frederic Weisbecker, (Sun Mar 28, 1:11 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Frederic Weisbecker, (Sun Mar 28, 1:15 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Frederic Weisbecker, (Sun Mar 28, 1:33 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Sun Mar 28, 2:34 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Andi Kleen, (Sun Mar 28, 2:58 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Frederic Weisbecker, (Sun Mar 28, 4:18 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Frederic Weisbecker, (Sun Mar 28, 4:24 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Frederic Weisbecker, (Sun Mar 28, 4:38 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock II, Andi Kleen, (Sun Mar 28, 6:07 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Mon Mar 29, 4:04 am)
Re: [GIT, RFC] Killing the Big Kernel Lock II, Arnd Bergmann, (Mon Mar 29, 4:48 am)
Re: [GIT, RFC] Killing the Big Kernel Lock II, Andi Kleen, (Mon Mar 29, 5:30 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, John Kacur, (Mon Mar 29, 5:45 am)
Re: [GIT, RFC] Killing the Big Kernel Lock II, Arnd Bergmann, (Mon Mar 29, 7:43 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, Frederic Weisbecker, (Mon Mar 29, 10:59 am)
Re: [GIT, RFC] Killing the Big Kernel Lock II, Andi Kleen, (Mon Mar 29, 1:11 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Mon Mar 29, 2:18 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Roland Dreier, (Tue Mar 30, 10:22 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Roland Dreier, (Wed Mar 31, 3:11 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Frederic Weisbecker, (Wed Mar 31, 3:20 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Thu Apr 1, 1:50 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, Jan Blunck, (Thu Apr 8, 1:45 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Arnd Bergmann, (Thu Apr 8, 2:27 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Frederic Weisbecker, (Thu Apr 8, 2:30 pm)
Re: [GIT, RFC] Killing the Big Kernel Lock, Jan Blunck, (Fri Apr 9, 4:02 am)
Re: [GIT, RFC] Killing the Big Kernel Lock, Stefan Richter, (Sat Apr 10, 8:13 am)