login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
April
»
11
Re: [PATCH] slub: __kmalloc_node_track_caller should trace kmalloc_large_node case
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Pekka Enberg
Subject:
Re: [PATCH] slub: __kmalloc_node_track_caller should trace kmalloc_large_node case
Date: Saturday, April 10, 2010 - 11:40 pm
David Rientjes wrote:
quoted text
> On Thu, 8 Apr 2010, Xiaotian Feng wrote: > >> commit 94b528d (kmemtrace: SLUB hooks for caller-tracking functions) >> missed tracing kmalloc_large_node in __kmalloc_node_track_caller. We >> should trace it same as __kmalloc_node. >> >> Signed-off-by: Xiaotian Feng <dfeng@redhat.com> >> Cc: Pekka Enberg <penberg@cs.helsinki.fi> >> Cc: Matt Mackall <mpm@selenic.com> >> Cc: David Rientjes <rientjes@google.com> > > Acked-by: David Rientjes <rientjes@google.com> > >> Cc: Ingo Molnar <mingo@elte.hu> >> Cc: Vegard Nossum <vegard.nossum@gmail.com> >> --- >> mm/slub.c | 11 +++++++++-- >> 1 files changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/mm/slub.c b/mm/slub.c >> index b364844..a3a5a18 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -3335,8 +3335,15 @@ void *__kmalloc_node_track_caller(size_t size, gfp_t gfpflags, >> struct kmem_cache *s; >> void *ret; >> >> - if (unlikely(size > SLUB_MAX_SIZE)) >> - return kmalloc_large_node(size, gfpflags, node); >> + if (unlikely(size > SLUB_MAX_SIZE)) { >> + ret = kmalloc_large_node(size, gfpflags, node); >> + >> + trace_kmalloc_node(caller, ret, >> + size, PAGE_SIZE << get_order(size), >> + gfpflags, node); >> + >> + return ret; >> + } >> >> s = get_slab(size, gfpflags); >>
Applied, thanks! --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] slub: __kmalloc_node_track_caller should trace kma ...
, Xiaotian Feng
, (Thu Apr 8, 2:26 am)
Re: [PATCH] slub: __kmalloc_node_track_caller should trace ...
, David Rientjes
, (Thu Apr 8, 12:03 pm)
Re: [PATCH] slub: __kmalloc_node_track_caller should trace ...
, Pekka Enberg
, (Sat Apr 10, 11:40 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
Og dreams of kernels
Jens Axboe
[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann
Re: finding your own dead "CONFIG_" variables
Mark Brown
[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds
[LGUEST] Look in object dir for .config
git
:
Brian Downing
Re: Git in a Nutshell guide
John Benes
Re: master has some toys
Matthias Lederhofer
[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian
[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano
Re: Rss produced by git is not valid xml?
git-commits-head
:
Linux Kernel Mailing List
iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List
ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List
ixgbe: fix several counter register errata
Linux Kernel Mailing List
b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List
9p: block-based virtio client
linux-netdev
:
Michael Breuer
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
David Daney
[PATCH 5/7] Staging: Octeon Ethernet: Convert to NAPI.