[PATCH -mm 1/4] oom: select_bad_process: check PF_KTHREAD instead of !mm to skip kthreads

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Oleg Nesterov
Date: Friday, April 2, 2010 - 11:31 am

select_bad_process() thinks a kernel thread can't have ->mm != NULL,
this is not true due to use_mm().

Change the code to check PF_KTHREAD.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---

 mm/oom_kill.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

--- MM/mm/oom_kill.c~1_FLITER_OUT_KTHREADS	2010-03-31 17:47:14.000000000 +0200
+++ MM/mm/oom_kill.c	2010-04-02 18:51:05.000000000 +0200
@@ -290,8 +290,8 @@ static struct task_struct *select_bad_pr
 	for_each_process(p) {
 		unsigned int points;
 
-		/* skip the init task */
-		if (is_global_init(p))
+		/* skip the init task and kthreads */
+		if (is_global_init(p) || (p->flags & PF_KTHREAD))
 			continue;
 		if (mem && !task_in_mem_cgroup(p, mem))
 			continue;
@@ -331,8 +331,7 @@ static struct task_struct *select_bad_pr
 		}
 
 		/*
-		 * skip kernel threads and tasks which have already released
-		 * their mm.
+		 * skip the tasks which have already released their mm.
 		 */
 		if (!p->mm)
 			continue;

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] oom killer: break from infinite loop, Anfei Zhou, (Wed Mar 24, 9:25 am)
Re: [PATCH] oom killer: break from infinite loop, KOSAKI Motohiro, (Wed Mar 24, 7:51 pm)
Re: [PATCH] oom killer: break from infinite loop, Andrew Morton, (Fri Mar 26, 3:08 pm)
Re: [PATCH] oom killer: break from infinite loop, Oleg Nesterov, (Fri Mar 26, 3:33 pm)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Sat Mar 27, 7:46 pm)
Re: [PATCH] oom killer: break from infinite loop, Oleg Nesterov, (Sun Mar 28, 9:28 am)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Sun Mar 28, 2:21 pm)
Re: [PATCH] oom killer: break from infinite loop, Oleg Nesterov, (Mon Mar 29, 4:21 am)
Re: [PATCH] oom killer: break from infinite loop, Oleg Nesterov, (Mon Mar 29, 4:46 am)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Mon Mar 29, 1:01 pm)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Tue Mar 30, 1:29 pm)
Re: [PATCH] oom killer: break from infinite loop, KAMEZAWA Hiroyuki, (Tue Mar 30, 5:57 pm)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Tue Mar 30, 11:07 pm)
Re: [PATCH] oom killer: break from infinite loop, KAMEZAWA Hiroyuki, (Tue Mar 30, 11:13 pm)
Re: [PATCH] oom killer: break from infinite loop, Balbir Singh, (Tue Mar 30, 11:30 pm)
Re: [PATCH] oom killer: break from infinite loop, KAMEZAWA Hiroyuki, (Tue Mar 30, 11:31 pm)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Tue Mar 30, 11:32 pm)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Wed Mar 31, 12:04 am)
Re: [PATCH] oom killer: break from infinite loop, Mel Gorman, (Fri Apr 2, 3:17 am)
[PATCH -mm 0/4] oom: linux has threads, Oleg Nesterov, (Fri Apr 2, 11:30 am)
[PATCH -mm 1/4] oom: select_bad_process: check PF_KTHREAD ..., Oleg Nesterov, (Fri Apr 2, 11:31 am)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Sun Apr 4, 4:26 pm)
Re: [PATCH] oom killer: break from infinite loop, Mel Gorman, (Mon Apr 5, 3:47 am)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Tue Apr 6, 3:40 pm)