Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Saturday, April 24, 2010 - 3:15 pm

On Sat, 24 Apr 2010, Arnd Bergmann wrote:

That has _nothing_ to do with the ioctl's though.

Stop mixing things up.

There are two totally independent issues:

 - making the BKL ioctl's be explicit and findable

 - eventually getting rid of the BKL entirely

and I think you guys are totally mixing things up, and making things WORSE 
in the process.

The notion of having _three_ different "ioctl()" function pointers just 
makes me want to gag. And there is absolutely _zero_ reason for it. Tjhere 
is no way in hell that we want to have every subsystem maintainer try to 
independently do their own ioctl's. Most of the drivers that have those 
things are basically unmaintained or on the back burner anyway.

So don't make the current ugly ioctl situation worse. Not even as a 
stop-gap, because there is absolutely _zero_ upside to making yet another 
new crazy temporary ioctl interface.

And don't try to conflate the issue of ioctl and BKL. There are still 
code-paths that do lock_kernel() without the ioctl's, so the whole ioctl 
renaming has _zero_ to do with CONFIG_BKL.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PULL] Preparation for BKL'ed ioctl removal, Frederic Weisbecker, (Thu Apr 15, 8:56 pm)
[GIT PULL v2] Preparation for BKL'ed ioctl removal, Frederic Weisbecker, (Wed Apr 21, 5:48 pm)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Frederic Weisbecker, (Sat Apr 24, 8:25 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Linus Torvalds, (Sat Apr 24, 11:36 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Linus Torvalds, (Sat Apr 24, 11:47 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Arnd Bergmann, (Sat Apr 24, 12:54 pm)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Linus Torvalds, (Sat Apr 24, 1:01 pm)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Arnd Bergmann, (Sat Apr 24, 1:40 pm)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Linus Torvalds, (Sat Apr 24, 3:15 pm)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Frederic Weisbecker, (Sun Apr 25, 10:39 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Linus Torvalds, (Sun Apr 25, 10:49 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Frederic Weisbecker, (Sun Apr 25, 11:05 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Ingo Molnar, (Mon Apr 26, 12:25 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Arnd Bergmann, (Mon Apr 26, 1:30 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Arnd Bergmann, (Mon Apr 26, 4:29 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Linus Torvalds, (Mon Apr 26, 11:08 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Arnd Bergmann, (Mon Apr 26, 12:12 pm)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Linus Torvalds, (Mon Apr 26, 1:36 pm)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, David Miller, (Mon Apr 26, 1:42 pm)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Frederic Weisbecker, (Mon Apr 26, 3:09 pm)
[PATCH 0/6] Push down BKL into device drivers, Arnd Bergmann, (Mon Apr 26, 3:23 pm)
[PATCH 1/6] dvb: push down BKL into ioctl functions, Arnd Bergmann, (Mon Apr 26, 3:24 pm)
[PATCH 2/6] scsi: push down BKL into ioctl functions, Arnd Bergmann, (Mon Apr 26, 3:24 pm)
[PATCH 3/6] isdn: push down BKL into ioctl functions, Arnd Bergmann, (Mon Apr 26, 3:24 pm)
[PATCH 4/6] staging: push down BKL into ioctl functions, Arnd Bergmann, (Mon Apr 26, 3:24 pm)
[PATCH 5/6] v4l: always use unlocked_ioctl, Arnd Bergmann, (Mon Apr 26, 3:24 pm)
[PATCH 6/6] drivers: push down BKL into various drivers, Arnd Bergmann, (Mon Apr 26, 3:24 pm)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Linus Torvalds, (Mon Apr 26, 3:32 pm)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Frederic Weisbecker, (Mon Apr 26, 4:04 pm)
Re: [PATCH 0/6] Push down BKL into device drivers, John Kacur, (Tue Apr 27, 2:14 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Ingo Molnar, (Tue Apr 27, 2:25 am)
Re: [PATCH 4/6] staging: push down BKL into ioctl functions, Frederic Weisbecker, (Tue Apr 27, 11:15 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Frederic Weisbecker, (Wed Apr 28, 6:21 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Ingo Molnar, (Wed Apr 28, 6:37 am)
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal, Arnd Bergmann, (Wed Apr 28, 7:05 am)