Re: [PATCH 09/14] Add /proc trigger for memory compaction

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Mel Gorman
Date: Wednesday, April 7, 2010 - 11:27 am

> mm,compaction: Tighten up the allowed values for compact_memory and initialisation

Minor mistake in the initialisation part of the patch

==== CUT HERE ====
mm,compaction: Initialise cc->zone at the correct time

Init cc->zone after we know what zone we are looking for. This is a fix
to the fix patch "mm,compaction: Tighten up the allowed values for
compact_memory and initialisation"

Signed-off-by: Mel Gorman <mel@csn.ul.ie>
---
 mm/compaction.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index d9c5733..effe57d 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -396,13 +396,13 @@ static int compact_node(int nid)
 		struct compact_control cc = {
 			.nr_freepages = 0,
 			.nr_migratepages = 0,
-			.zone = zone,
 		};
 
 		zone = &pgdat->node_zones[zoneid];
 		if (!populated_zone(zone))
 			continue;
 
+		cc.zone = zone,
 		INIT_LIST_HEAD(&cc.freepages);
 		INIT_LIST_HEAD(&cc.migratepages);
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/14] Memory Compaction v7, Mel Gorman, (Fri Apr 2, 9:02 am)
[PATCH 08/14] Memory compaction core, Mel Gorman, (Fri Apr 2, 9:02 am)
Re: [PATCH 14/14] mm,migration: Allow the migration of Pag ..., KAMEZAWA Hiroyuki, (Mon Apr 5, 11:54 pm)
[No subject], Tarkan Erimer, (Tue Apr 6, 7:47 am)
[No subject], Mel Gorman, (Tue Apr 6, 8:00 am)
[No subject], Tarkan Erimer, (Tue Apr 6, 8:03 am)
[No subject], Minchan Kim, (Tue Apr 6, 8:37 am)
Re: [PATCH 08/14] Memory compaction core, Andrew Morton, (Tue Apr 6, 5:05 pm)
Re: [PATCH 08/14] Memory compaction core, Mel Gorman, (Wed Apr 7, 8:21 am)
Re: [PATCH 09/14] Add /proc trigger for memory compaction, Mel Gorman, (Wed Apr 7, 11:27 am)
Re: [PATCH 08/14] Memory compaction core, Mel Gorman, (Thu Apr 8, 9:59 am)
Re: [PATCH 08/14] Memory compaction core, Andrea Arcangeli, (Thu Apr 8, 10:06 am)