login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
May
»
3
Re: [PATCH v3] firmware_class: fix memory leak - free allocated pages
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Greg KH
Subject:
Re: [PATCH v3] firmware_class: fix memory leak - free allocated pages
Date: Monday, May 3, 2010 - 10:04 am
On Sun, May 02, 2010 at 11:21:21AM +0300, Tomas Winkler wrote:
quoted text
> From: David Woodhouse <David.Woodhouse@intel.com> > > fix memory leak introduced by the patch 6e03a201bbe: > firmware: speed up request_firmware() > > 1. vfree won't release pages there were allocated explicitly and mapped > using vmap. The memory has to be vunmap-ed and the pages needs > to be freed explicitly > > 2. page array is moved into the 'struct > firmware' so that we can free it from release_firmware() > and not only in fw_dev_release() > > The fix doesn't break the firmware load speed. > > Cc: Johannes Berg <johannes@sipsolutions.net> > Cc: Greg Kroah-Hartman <gregkh@suse.de> > Cc: Ming Lei <tom.leiming@gmail.com> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Singed-off-by: Kay Sievers <kay.sievers@vrfy.org> > Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > --- > V2: fix authorship of the patch > V3: fix const struct firmware breakage
Thanks, this looks much better, I've applied it now. greg k-h --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH v3] firmware_class: fix memory leak - free allocate ...
, Tomas Winkler
, (Sun May 2, 1:21 am)
Re: [PATCH v3] firmware_class: fix memory leak - free allo ...
, Greg KH
, (Mon May 3, 10:04 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
Og dreams of kernels
Jens Axboe
[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann
Re: finding your own dead "CONFIG_" variables
Mark Brown
[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds
[LGUEST] Look in object dir for .config
git
:
Brian Downing
Re: Git in a Nutshell guide
John Benes
Re: master has some toys
Matthias Lederhofer
[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian
[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano
Re: Rss produced by git is not valid xml?
git-commits-head
:
Linux Kernel Mailing List
iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List
ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List
ixgbe: fix several counter register errata
Linux Kernel Mailing List
b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List
9p: block-based virtio client
linux-netdev
:
<