[Re-added linux-pci, which got lost again somewhere.]
On Monday, May 31, 2010 05:12:00 am Mike Travis wrote:
I'm disappointed that you didn't rework this to make it generic,
not x86-specific. That would be pretty easy and would remove
the need for somebody else to come and clean it up later.
I'm sorry; I don't follow this. BIOS assigns MMIO BARs regardless
of whether we have your patch.
I'm still having trouble reconciling the stated purpose, i.e., the
changelog, with the behavior. The changelog implies that the patch
is required to make >16 devices with I/O BARs work at all, but per
Mike Habeck, the patch just gets rid of some warnings and maybe helps
with hot-add of devices using I/O space.
Is there a deeper problem that happens if we exhaust I/O space?
Are we releasing device resources in pci_assign_unassigned_bridge_resources()
and then we fail to reassign even MMIO resources after we exhaust
Maybe a complete dmesg log showing the failure would be helpful. if
so, you could open a kernel.org bugzilla and reference it in your
changelog so we can take this issue into account in future PCI work.