Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp->msgq_txseq' may be undefined

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Howells
Date: Monday, June 28, 2010 - 5:52 am

Justin P. Mattock <justinmattock@gmail.com> wrote:


I don't know what you're trying to do here, but you seem to be trying to send
the computed value back in time.

The problem is that the compiler is confused about why a '++' operator makes
any sense here.  It doesn't.  It should be a '+ 1' instead.  I think what you
want is:

	-	bcsp->msgq_txseq = ++(bcsp->msgq_txseq) & 0x07;
	+	bcsp->msgq_txseq = (bcsp->msgq_txseq + 1) & 0x07;

David
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/5] Fix gcc 4.6.0 set but unused variable warnings , Justin P. Mattock, (Sat Jun 26, 11:47 pm)
[PATCH 1/5]security:key.c Fix warning: variable 'key' set ..., Justin P. Mattock, (Sat Jun 26, 11:47 pm)
[PATCH 2/5]security:ebitmap.c Fix warning: variable 'e_sft ..., Justin P. Mattock, (Sat Jun 26, 11:47 pm)
[PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but ..., Justin P. Mattock, (Sat Jun 26, 11:47 pm)
[PATCH 4/5]block:cryptoloop Fix warning: variable 'cipher' ..., Justin P. Mattock, (Sat Jun 26, 11:47 pm)
Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp-&gt; ..., Gustavo F. Padovan, (Sun Jun 27, 12:31 am)
Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp-> ..., David Howells, (Mon Jun 28, 5:52 am)
[PATCH] Bluetooth: Fix abuse of the preincrement operator, David Howells, (Mon Jun 28, 5:57 am)
Re: [PATCH] Bluetooth: Fix abuse of the preincrement operator, Gustavo F. Padovan, (Mon Jun 28, 6:12 am)
Re: [PATCH] Bluetooth: Fix abuse of the preincrement operator, Justin P. Mattock, (Mon Jun 28, 10:44 am)
Re: [PATCH 1/5]security:key.c Fix warning: variable 'key' ..., Justin P. Mattock, (Mon Jun 28, 10:48 am)
Re: [PATCH 2/5]security:ebitmap.c Fix warning: variable 'e ..., Justin P. Mattock, (Mon Jun 28, 10:49 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Mon Jun 28, 10:52 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Mon Jun 28, 12:03 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Mon Jun 28, 12:08 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Mon Jun 28, 8:23 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Tue Jun 29, 10:14 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Tue Jun 29, 2:53 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Wed Jun 30, 6:21 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Wed Jun 30, 12:47 pm)