login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
June
»
28
Re: [PATCH 1/5]security:key.c Fix warning: variable 'key' set but not used
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Justin P. Mattock
Subject:
Re: [PATCH 1/5]security:key.c Fix warning: variable 'key' set but not used
Date: Monday, June 28, 2010 - 10:48 am
On 06/28/2010 05:38 AM, David Howells wrote:
quoted text
> Justin P. Mattock<justinmattock@gmail.com> wrote: > >> In this case the safest approach(in my mind) would be to just >> mark the integer __unused. Keep in mind though Im not certain >> if this is the right place for this value i.e. will this effect >> *instkey or not(please check). > > This is the wrong approach. Either the variable should be got rid of, or it > should be used to replace all the other calls to key_ref_to_ptr() in > keyctl_describe_key(). > > David >
I see your patch you sent for this.. vary nice! Thanks! Justin P. Mattock --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 0/5] Fix gcc 4.6.0 set but unused variable warnings
, Justin P. Mattock
, (Sat Jun 26, 11:47 pm)
[PATCH 1/5]security:key.c Fix warning: variable 'key' set ...
, Justin P. Mattock
, (Sat Jun 26, 11:47 pm)
[PATCH 2/5]security:ebitmap.c Fix warning: variable 'e_sft ...
, Justin P. Mattock
, (Sat Jun 26, 11:47 pm)
[PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but ...
, Justin P. Mattock
, (Sat Jun 26, 11:47 pm)
[PATCH 4/5]block:cryptoloop Fix warning: variable 'cipher' ...
, Justin P. Mattock
, (Sat Jun 26, 11:47 pm)
[PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp->msgq ...
, Justin P. Mattock
, (Sat Jun 26, 11:47 pm)
Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp-> ...
, Gustavo F. Padovan
, (Sun Jun 27, 12:31 am)
Re: [PATCH 1/5]security:key.c Fix warning: variable 'key' ...
, David Howells
, (Mon Jun 28, 5:38 am)
Re: [PATCH 2/5]security:ebitmap.c Fix warning: variable 'e ...
, David Howells
, (Mon Jun 28, 5:44 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, David Howells
, (Mon Jun 28, 5:48 am)
Re: [PATCH 4/5]block:cryptoloop Fix warning: variable 'cip ...
, David Howells
, (Mon Jun 28, 5:49 am)
Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp-> ...
, David Howells
, (Mon Jun 28, 5:52 am)
[PATCH] Bluetooth: Fix abuse of the preincrement operator
, David Howells
, (Mon Jun 28, 5:57 am)
Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp-> ...
, Bernd Petrovitsch
, (Mon Jun 28, 6:02 am)
[PATCH] KEYS: Use the variable 'key' in keyctl_describe_key()
, David Howells
, (Mon Jun 28, 6:05 am)
Re: [PATCH] Bluetooth: Fix abuse of the preincrement operator
, Gustavo F. Padovan
, (Mon Jun 28, 6:12 am)
Re: [PATCH] Bluetooth: Fix abuse of the preincrement operator
, Justin P. Mattock
, (Mon Jun 28, 10:44 am)
Re: [PATCH 1/5]security:key.c Fix warning: variable 'key' ...
, Justin P. Mattock
, (Mon Jun 28, 10:48 am)
Re: [PATCH 2/5]security:ebitmap.c Fix warning: variable 'e ...
, Justin P. Mattock
, (Mon Jun 28, 10:49 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, Justin P. Mattock
, (Mon Jun 28, 10:52 am)
Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp-> ...
, Justin P. Mattock
, (Mon Jun 28, 10:56 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, David Howells
, (Mon Jun 28, 11:47 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, Justin P. Mattock
, (Mon Jun 28, 12:03 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, Justin P. Mattock
, (Mon Jun 28, 12:08 pm)
Re: [Keyrings] [PATCH] KEYS: Use the variable 'key' in key ...
, James Morris
, (Mon Jun 28, 4:01 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, Justin P. Mattock
, (Mon Jun 28, 8:23 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, David Howells
, (Tue Jun 29, 8:47 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, Justin P. Mattock
, (Tue Jun 29, 10:14 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, Justin P. Mattock
, (Tue Jun 29, 2:53 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, David Howells
, (Wed Jun 30, 2:13 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, Justin P. Mattock
, (Wed Jun 30, 6:21 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, Justin P. Mattock
, (Wed Jun 30, 12:47 pm)
Re: [PATCH] Bluetooth: Fix abuse of the preincrement operator
, David Miller
, (Wed Jun 30, 1:10 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, David Howells
, (Thu Jul 1, 2:31 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, Justin P. Mattock
, (Thu Jul 1, 6:41 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, Justin P. Mattock
, (Thu Jul 1, 1:01 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, David Howells
, (Thu Jul 1, 5:10 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ...
, Justin P. Mattock
, (Thu Jul 1, 5:59 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
Og dreams of kernels
Jens Axboe
[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann
Re: finding your own dead "CONFIG_" variables
Mark Brown
[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds
[LGUEST] Look in object dir for .config
git
:
Brian Downing
Re: Git in a Nutshell guide
John Benes
Re: master has some toys
Matthias Lederhofer
[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian
[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano
Re: Rss produced by git is not valid xml?
git-commits-head
:
Linux Kernel Mailing List
iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List
ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List
ixgbe: fix several counter register errata
Linux Kernel Mailing List
b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List
9p: block-based virtio client
linux-netdev
:
Michael Breuer
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
David Daney
[PATCH 5/7] Staging: Octeon Ethernet: Convert to NAPI.
Wolfgang Grandegger
[PATCH net-next v4 1/3] can: mscan: fix improper return if dlc < 8 in start_xmi...
Amit Kumar Salecha
[PATCHv3 NEXT 2/2] NET: Add Qlogic ethernet driver for CNA devices
openbsd-misc
:
Theo de Raadt
Re: Old IPSEC bug
Tomáš Bodžár
Problem with vpnc connection - check group password !
Insan Praja SW
Mandoc Compiling Error
Carl Roberso
Re: Cannot change MTU of carp interface?
Richard Daemon