Home » Mailing list archives » linux-kernel » 2010 » June » 28

Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but not used

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Justin P. Mattock
Subject: Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but not used
Date: Monday, June 28, 2010 - 12:03 pm

On 06/28/2010 11:47 AM, David Howells wrote:

not sure if it would give warnings for not capturing the result.
then doing this would be the way to go.

if (ret) {
printk(KERN_WARNING "dev%d: Failed to create physical_node sysfs link: 
%d\n");
}

but like you had said unnecessary braces, and only one statement
I'll look at this some more too see if I come up with anything.

Justin P. Mattock
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/5] Fix gcc 4.6.0 set but unused variable warnings , Justin P. Mattock, (Sat Jun 26, 11:47 pm)
[PATCH 1/5]security:key.c Fix warning: variable 'key' set ..., Justin P. Mattock, (Sat Jun 26, 11:47 pm)
[PATCH 2/5]security:ebitmap.c Fix warning: variable 'e_sft ..., Justin P. Mattock, (Sat Jun 26, 11:47 pm)
[PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but ..., Justin P. Mattock, (Sat Jun 26, 11:47 pm)
[PATCH 4/5]block:cryptoloop Fix warning: variable 'cipher' ..., Justin P. Mattock, (Sat Jun 26, 11:47 pm)
[PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp->msgq ..., Justin P. Mattock, (Sat Jun 26, 11:47 pm)
Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp-> ..., Gustavo F. Padovan, (Sun Jun 27, 12:31 am)
Re: [PATCH 1/5]security:key.c Fix warning: variable 'key' ..., David Howells, (Mon Jun 28, 5:38 am)
Re: [PATCH 2/5]security:ebitmap.c Fix warning: variable 'e ..., David Howells, (Mon Jun 28, 5:44 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., David Howells, (Mon Jun 28, 5:48 am)
Re: [PATCH 4/5]block:cryptoloop Fix warning: variable 'cip ..., David Howells, (Mon Jun 28, 5:49 am)
Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp-> ..., David Howells, (Mon Jun 28, 5:52 am)
[PATCH] Bluetooth: Fix abuse of the preincrement operator, David Howells, (Mon Jun 28, 5:57 am)
Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp-> ..., Bernd Petrovitsch, (Mon Jun 28, 6:02 am)
[PATCH] KEYS: Use the variable 'key' in keyctl_describe_key(), David Howells, (Mon Jun 28, 6:05 am)
Re: [PATCH] Bluetooth: Fix abuse of the preincrement operator, Gustavo F. Padovan, (Mon Jun 28, 6:12 am)
Re: [PATCH] Bluetooth: Fix abuse of the preincrement operator, Justin P. Mattock, (Mon Jun 28, 10:44 am)
Re: [PATCH 1/5]security:key.c Fix warning: variable 'key' ..., Justin P. Mattock, (Mon Jun 28, 10:48 am)
Re: [PATCH 2/5]security:ebitmap.c Fix warning: variable 'e ..., Justin P. Mattock, (Mon Jun 28, 10:49 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Mon Jun 28, 10:52 am)
Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp-> ..., Justin P. Mattock, (Mon Jun 28, 10:56 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., David Howells, (Mon Jun 28, 11:47 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Mon Jun 28, 12:03 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Mon Jun 28, 12:08 pm)
Re: [Keyrings] [PATCH] KEYS: Use the variable 'key' in key ..., James Morris, (Mon Jun 28, 4:01 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Mon Jun 28, 8:23 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., David Howells, (Tue Jun 29, 8:47 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Tue Jun 29, 10:14 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Tue Jun 29, 2:53 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., David Howells, (Wed Jun 30, 2:13 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Wed Jun 30, 6:21 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Wed Jun 30, 12:47 pm)
Re: [PATCH] Bluetooth: Fix abuse of the preincrement operator, David Miller, (Wed Jun 30, 1:10 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., David Howells, (Thu Jul 1, 2:31 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Thu Jul 1, 6:41 am)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Thu Jul 1, 1:01 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., David Howells, (Thu Jul 1, 5:10 pm)
Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set ..., Justin P. Mattock, (Thu Jul 1, 5:59 pm)