Re: [PATCH 3/9] Removing dead CONFIG_SIBYTE_BCM1480_PROF

Previous thread: [PATCH 2/9] Removing dead CONFIG_GDB_CONSOLE by Christoph Egger on Wednesday, June 9, 2010 - 4:20 am. (3 messages)

Next thread: [PATCH 4/9] Removing dead CONFIG_MTD_PB1550_BOOT, CONFIG_MTD_PB1550_USER by Christoph Egger on Wednesday, June 9, 2010 - 4:21 am. (2 messages)
From: Christoph Egger
Date: Wednesday, June 9, 2010 - 4:21 am

CONFIG_SIBYTE_BCM1480_PROF doesn't exist in Kconfig, therefore removing all
references for it from the source code.

Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
---
 arch/mips/sibyte/bcm1480/irq.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/arch/mips/sibyte/bcm1480/irq.c b/arch/mips/sibyte/bcm1480/irq.c
index 044bbe4..919d2d5 100644
--- a/arch/mips/sibyte/bcm1480/irq.c
+++ b/arch/mips/sibyte/bcm1480/irq.c
@@ -362,19 +362,8 @@ asmlinkage void plat_irq_dispatch(void)
 	unsigned int cpu = smp_processor_id();
 	unsigned int pending;
 
-#ifdef CONFIG_SIBYTE_BCM1480_PROF
-	/* Set compare to count to silence count/compare timer interrupts */
-	write_c0_compare(read_c0_count());
-#endif
-
 	pending = read_c0_cause() & read_c0_status();
 
-#ifdef CONFIG_SIBYTE_BCM1480_PROF
-	if (pending & CAUSEF_IP7)	/* Cpu performance counter interrupt */
-		sbprof_cpu_intr();
-	else
-#endif
-
 	if (pending & CAUSEF_IP4)
 		do_IRQ(K_BCM1480_INT_TIMER_0 + cpu);
 #ifdef CONFIG_SMP
-- 
1.6.3.3

--

From: Jiri Kosina
Date: Wednesday, June 16, 2010 - 9:00 am

The patch isn't present in linux-next as of today. I have applied it to my 

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--

From: Ralf Baechle
Date: Monday, June 28, 2010 - 6:49 am

Nack.  This only need to be rewired to use the ZBus profiler just like
the SB1250 already does.  It's the virtually same hardware after all!

  Ralf
--

From: Jiri Kosina
Date: Wednesday, June 30, 2010 - 2:36 am

Well, still it's dead code guarded by ifdef depending on non-exsiting 
symbol ... I have just quickly tried to get a grip on the zbus thing, but

	arch/mips/configs/bigsur_defconfig:CONFIG_SIBYTE_HAS_ZBUS_PROFILING=y
	arch/mips/configs/sb1250-swarm_defconfig:CONFIG_SIBYTE_HAS_ZBUS_PROFILING=y
	1arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       depends on SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:config SIBYTE_HAS_ZBUS_PROFILING

seem to be the only occurences in the whole tree. Another unused symbol?

So I'll revert that patch in my tree as it has been nacked by maintainer, 
but the feeling that cleanup is needed is still there.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--

From: Maciej W. Rozycki
Date: Wednesday, June 30, 2010 - 6:35 am

... this:

	arch/mips/sibyte/Kconfig:	config SIBYTE_TBPROF


 Not quite so then.

  Maciej
--

From: Jiri Kosina
Date: Wednesday, June 30, 2010 - 6:38 am

Right you are, sorry for the noise.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--

From: Ralf Baechle
Date: Wednesday, June 30, 2010 - 8:15 am

So I've dropped this one from my o