Re: [PATCH 1/2] block: fix leaks associated with discard request payload | KernelTrap

Re: [PATCH 1/2] block: fix leaks associated with discard request payload

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: FUJITA Tomonori

Subject: Re: [PATCH 1/2] block: fix leaks associated with discard request payload

Date: Wednesday, June 30, 2010 - 4:55 am

On Mon, 28 Jun 2010 17:25:36 +0200
Christoph Hellwig <hch@lst.de> wrote:

quoted text> On Mon, Jun 28, 2010 at 05:14:28PM +0900, FUJITA Tomonori wrote:
> > > While I see the problems with leaking ressources in that case I still
> > > can't quite explain the hang I see.
> > 
> > Any way to reproduce the hang without ssd drives?
> 
> Actually the SSDs don't fully hang, they just causes lots of I/O errors
> and hit the error handler hard.  The hard hang is when running under
> qemu.  Apply the patch below, then create an if=scsi drive that resides
> on an XFS filesystem, and you'll have scsi TP support in the guest:

Ok, I figured out what's wrong.

As I suspected, it's due to the partial completion.

qemu scsi driver tells that the WRITE_SAME command was successful but
somehow the command has resid. So we retry it again and again (and
leak some memory).

I don't know yet why qemu scsi driver is broken. Maybe there is a bug
in it or converting discard to FS sends broken commands to the driver.

I'll try to figure out it tomorrow.

I've put a patch to complete discard command in the all-or-nothing
manner:

git://git.kernel.org/pub/scm/linux/kernel/git/tomo/linux-2.6-misc.git discard

At least, the guest kernel doesn't hang for me.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH, RFC] block: don't allocate a payload for discard r ..., Christoph Hellwig, (Fri Jun 18, 7:59 am)

Re: [PATCH, RFC] block: don't allocate a payload for disca ..., Mike Snitzer, (Fri Jun 18, 9:25 pm)

Re: [PATCH, RFC] block: don't allocate a payload for disca ..., Mike Snitzer, (Tue Jun 22, 11:00 am)

[PATCH 1/2] block: fix leaks associated with discard reque ..., Mike Snitzer, (Sat Jun 26, 12:56 pm)

[PATCH 2/2] block: defer the use of inline biovecs for dis ..., Mike Snitzer, (Sat Jun 26, 12:56 pm)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., FUJITA Tomonori, (Sun Jun 27, 1:49 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Christoph Hellwig, (Sun Jun 27, 2:26 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Christoph Hellwig, (Sun Jun 27, 2:38 am)

Re: [PATCH 2/2] block: defer the use of inline biovecs for ..., Christoph Hellwig, (Sun Jun 27, 2:39 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., FUJITA Tomonori, (Sun Jun 27, 3:01 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., FUJITA Tomonori, (Sun Jun 27, 3:35 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Christoph Hellwig, (Sun Jun 27, 4:07 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., FUJITA Tomonori, (Sun Jun 27, 5:32 am)

Re: [PATCH 2/2] block: defer the use of inline biovecs for ..., Mike Snitzer, (Sun Jun 27, 7:00 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Mike Snitzer, (Sun Jun 27, 7:16 am)

[PATCH 2/2 v2] block: defer the use of inline biovecs for ..., Mike Snitzer, (Sun Jun 27, 7:55 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Christoph Hellwig, (Sun Jun 27, 8:33 am)

Re: [PATCH 2/2 v2] block: defer the use of inline biovecs ..., Christoph Hellwig, (Sun Jun 27, 8:33 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Christoph Hellwig, (Sun Jun 27, 8:35 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., FUJITA Tomonori, (Sun Jun 27, 9:23 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Christoph Hellwig, (Mon Jun 28, 12:57 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Jens Axboe, (Mon Jun 28, 1:18 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., FUJITA Tomonori, (Mon Jun 28, 1:45 am)

Re: [PATCH 2/2] block: defer the use of inline biovecs for ..., FUJITA Tomonori, (Mon Jun 28, 3:33 am)

Re: [PATCH 2/2] block: defer the use of inline biovecs for ..., Mike Snitzer, (Mon Jun 28, 5:29 am)

Re: [PATCH 2/2] block: defer the use of inline biovecs for ..., Jens Axboe, (Mon Jun 28, 5:34 am)

Re: [PATCH 2/2] block: defer the use of inline biovecs for ..., Mike Snitzer, (Mon Jun 28, 5:37 am)

Re: [PATCH 2/2] block: defer the use of inline biovecs for ..., Jens Axboe, (Mon Jun 28, 5:41 am)

Re: [PATCH 2/2] block: defer the use of inline biovecs for ..., Christoph Hellwig, (Mon Jun 28, 5:44 am)

Re: [PATCH 2/2] block: defer the use of inline biovecs for ..., Mike Snitzer, (Mon Jun 28, 5:45 am)

Re: [PATCH 2/2] block: defer the use of inline biovecs for ..., Jens Axboe, (Mon Jun 28, 5:49 am)

Re: [PATCH 2/2] block: defer the use of inline biovecs for ..., FUJITA Tomonori, (Mon Jun 28, 8:15 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Christoph Hellwig, (Mon Jun 28, 8:25 am)

Re: [PATCH 2/2] block: defer the use of inline biovecs for ..., Mike Snitzer, (Mon Jun 28, 8:31 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Martin K. Petersen, (Mon Jun 28, 10:16 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Boaz Harrosh, (Tue Jun 29, 1:00 am)

Re: [dm-devel] [PATCH 1/2] block: fix leaks associated wit ..., Mikulas Patocka, (Tue Jun 29, 3:28 pm)

Re: [dm-devel] [PATCH 1/2] block: fix leaks associated wit ..., James Bottomley, (Tue Jun 29, 4:03 pm)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Mike Snitzer, (Tue Jun 29, 4:51 pm)

Re: [dm-devel] [PATCH 1/2] block: fix leaks associated wit ..., Mikulas Patocka, (Tue Jun 29, 5:11 pm)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Boaz Harrosh, (Wed Jun 30, 1:32 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Christoph Hellwig, (Wed Jun 30, 1:42 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Christoph Hellwig, (Wed Jun 30, 3:41 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Boaz Harrosh, (Wed Jun 30, 3:57 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., FUJITA Tomonori, (Wed Jun 30, 4:55 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Mike Snitzer, (Wed Jun 30, 5:18 am)

Re: [dm-devel] [PATCH 1/2] block: fix leaks associated wit ..., James Bottomley, (Wed Jun 30, 7:22 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Mike Snitzer, (Wed Jun 30, 8:36 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., James Bottomley, (Wed Jun 30, 9:26 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., FUJITA Tomonori, (Wed Jun 30, 9:21 pm)

Re: [dm-devel] [PATCH 1/2] block: fix leaks associated wit ..., Mikulas Patocka, (Thu Jul 1, 5:28 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Mike Snitzer, (Thu Jul 1, 5:46 am)

Re: [dm-devel] [PATCH 1/2] block: fix leaks associated wit ..., Alasdair G Kergon, (Thu Jul 1, 5:49 am)

Re: [PATCH 1/2] block: fix leaks associated with discard r ..., Mikulas Patocka, (Thu Jul 1, 7:03 am)