Home » Mailing list archives » linux-kernel » 2010 » June » 9

[PATCH 2/2 -next] niu: always include of_device.h

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Randy Dunlap
Subject: [PATCH 2/2 -next] niu: always include of_device.h
Date: Wednesday, June 9, 2010 - 3:44 pm

From: Randy Dunlap <randy.dunlap@oracle.com>

The niu driver uses struct of_device when built on any arch, not
only SPARC64, so always #include <linux/of_device.h>.

drivers/net/niu.c:9700: warning: 'struct of_device' declared inside parameter list
drivers/net/niu.c:9700: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/net/niu.c:9716: warning: assignment from incompatible pointer type

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc:	Grant Likely <grant.likely@secretlab.ca>
Cc:	Dave Miller <davem@davemloft.net>
---
 drivers/net/niu.c |    3 ---
 1 file changed, 3 deletions(-)

--- linux-next-20100609.orig/drivers/net/niu.c
+++ linux-next-20100609/drivers/net/niu.c
@@ -28,10 +28,7 @@
 #include <linux/slab.h>
 
 #include <linux/io.h>
-
-#ifdef CONFIG_SPARC64
 #include <linux/of_device.h>
-#endif
 
 #include "niu.h"
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
linux-next: Tree for June 9, Stephen Rothwell, (Tue Jun 8, 8:34 pm)
Re: linux-next: Tree for June 9 (niu), Randy Dunlap, (Wed Jun 9, 10:36 am)
Re: linux-next: Tree for June 9 (niu), David Miller, (Wed Jun 9, 11:06 am)
Re: linux-next: Tree for June 9 (niu), Randy Dunlap, (Wed Jun 9, 11:08 am)
[PATCH] input: fixup X86_MRST selects, Randy Dunlap, (Wed Jun 9, 3:29 pm)
Re: [PATCH] input: fixup X86_MRST selects, Dmitry Torokhov, (Wed Jun 9, 3:40 pm)
Re: [PATCH] input: fixup X86_MRST selects, Randy Dunlap, (Wed Jun 9, 3:42 pm)
[PATCH 1/2 -next] of_device.h: provide struct of_device ev ..., Randy Dunlap, (Wed Jun 9, 3:44 pm)
[PATCH 2/2 -next] niu: always include of_device.h, Randy Dunlap, (Wed Jun 9, 3:44 pm)
Re: [PATCH 2/2 -next] niu: always include of_device.h, Grant Likely, (Wed Jun 9, 4:45 pm)
Re: [PATCH 1/2 -next] of_device.h: provide struct of_devic ..., Grant Likely, (Wed Jun 9, 4:47 pm)
Re: [PATCH 2/2 -next] niu: always include of_device.h, David Miller, (Wed Jun 9, 5:29 pm)
Re: [PATCH] input: fixup X86_MRST selects, Dmitry Torokhov, (Thu Jun 10, 12:04 pm)
Re: [PATCH] input: fixup X86_MRST selects, Randy Dunlap, (Tue Jun 15, 8:17 am)
problem: Re: [PATCH] input: fixup X86_MRST selects, Randy Dunlap, (Mon Jun 28, 12:03 pm)
Re: problem: Re: [PATCH] input: fixup X86_MRST selects, Dmitry Torokhov, (Mon Jun 28, 1:18 pm)
Re: problem: Re: [PATCH] input: fixup X86_MRST selects, Randy Dunlap, (Mon Jun 28, 1:23 pm)
RE: problem: Re: [PATCH] input: fixup X86_MRST selects, Pan, Jacob jun, (Mon Jun 28, 2:12 pm)
Re: problem: Re: [PATCH] input: fixup X86_MRST selects, Dmitry Torokhov, (Mon Jun 28, 3:44 pm)
RE: problem: Re: [PATCH] input: fixup X86_MRST selects, Pan, Jacob jun, (Mon Jun 28, 4:22 pm)
Re: problem: Re: [PATCH] input: fixup X86_MRST selects, Dmitry Torokhov, (Thu Jul 1, 9:46 pm)
Re: problem: Re: [PATCH] input: fixup X86_MRST selects, H. Peter Anvin, (Thu Jul 1, 11:27 pm)