Home » Mailing list archives » linux-kernel » 2010 » July » 8

Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number

Previous thread: [PATCH]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used by Justin P. Mattock on Thursday, July 8, 2010 - 12:09 pm. (3 messages)

Next thread: GSoC 2010 - Migration from memory ballooning to memory hotplug in Xen by Daniel Kiper on Thursday, July 8, 2010 - 12:45 pm. (11 messages)
[view original message]
From: David Brownell
Subject: Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number
Date: Thursday, July 8, 2010 - 12:31 pm

Can it be made to do so only when the gadget
hasn't been provided with one already?  Serial
number module options are standard parts of the
composite gadget framework...


--


[ message continues ]
[view original message]
From: Michał Nazarewicz
Subject: Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number
Date: Thursday, July 8, 2010 - 1:02 pm

I don't see a way for the gadget to know whether user gave the iSerialNumber
parameter (other then reading the iSerialNumber variable but I consider that
ugly).

Plus, in any event, gadget has to reserve a string ID for serial number
anyway.  Otherwise composite won't override the string.


PS. I've just spotted a bug in Yann's patch (string is not filled if
CONFIG_USB_FILE_STORAGE_TEST is undefined).  It's a trivial issue so
I'll fix it with updated version.

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--


[ message continues ]
Previous thread: [PATCH]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used by Justin P. Mattock on Thursday, July 8, 2010 - 12:09 pm. (3 messages)

Next thread: GSoC 2010 - Migration from memory ballooning to memory hotplug in Xen by Daniel Kiper on Thursday, July 8, 2010 - 12:45 pm. (11 messages)