Re: [PATCHSET block#for-2.6.36-post] block: replace barrier with sequenced flush

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Christoph Hellwig
Date: Friday, August 13, 2010 - 4:48 am

The patchset looks functionally correct to me, and with a small patch
to make use of WRITE_FUA_FLUSH survives xfstests, and instrumenting the
underlying qemu shows that we actually get the flush requests where we should.

No performance or power fail testing done yet.

But I do not like the transition very much.  The new WRITE_FUA_FLUSH
request is exactly what filesystems expect from a current barrier
request, so I'd rather move to that functionality without breaking stuff
inbetween.

So if it was to me I'd keep patches 1, 2, 4 and 5 from your series, than
a main one to relax barrier semantics, then have the renaming patches 7
and 8, and possible keep patch 11 separate from the main implementation
change, and if absolutely also a separate one to introduce REQ_FUA and
REQ_FLUSH in the bio interface, but keep things working while doing
this.

Then we can patches do disable the reiserfs barrier "optimization" as
the very first one, and DM/MD support which I'm currently working on
as the last one and we can start doing the heavy testing.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 02/11] block: kill QUEUE_ORDERED_BY_TAG, Tejun Heo, (Thu Aug 12, 5:41 am)
[PATCH 05/11] block: misc cleanups in barrier code, Tejun Heo, (Thu Aug 12, 5:41 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Fri Aug 13, 4:48 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Vladislav Bolkhovitin, (Fri Aug 13, 5:55 am)
Re: [PATCH 02/11] block: kill QUEUE_ORDERED_BY_TAG, Vladislav Bolkhovitin, (Fri Aug 13, 5:56 am)
Re: [PATCH 02/11] block: kill QUEUE_ORDERED_BY_TAG, Christoph Hellwig, (Fri Aug 13, 6:06 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Fri Aug 13, 6:17 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Fri Aug 13, 7:38 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Sat Aug 14, 3:36 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Tue Aug 17, 6:19 am)
Re: [PATCH 08/11] block: rename barrier/ordered to flush, Christoph Hellwig, (Tue Aug 17, 6:26 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Tue Aug 17, 9:59 am)
Re: [PATCH 08/11] block: rename barrier/ordered to flush, Christoph Hellwig, (Tue Aug 17, 10:08 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Wed Aug 18, 2:46 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Vladislav Bolkhovitin, (Wed Aug 18, 12:29 pm)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Vladislav Bolkhovitin, (Wed Aug 18, 12:30 pm)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Thu Aug 19, 3:20 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Fri Aug 20, 6:22 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Mon Aug 23, 5:48 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Mon Aug 23, 7:05 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Mon Aug 23, 7:08 am)
[PATCH] block: simplify queue_next_fseq, Christoph Hellwig, (Mon Aug 23, 7:15 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Christoph Hellwig, (Mon Aug 23, 7:19 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Vladislav Bolkhovitin, (Tue Aug 24, 10:11 am)
Re: [PATCHSET block#for-2.6.36-post] block: replace barrie ..., Vladislav Bolkhovitin, (Mon Aug 30, 1:34 pm)