[PATCH][resend] scripts/mod/modpost.c: fix commentary accordingly to last changes

Previous thread: [PATCH] scripts/mod/modpost.c: fix commentary accordingly to last changes by Andy Shevchenko on Tuesday, August 17, 2010 - 3:32 am. (1 message)

Next thread: Email Quota Limit Exceeded!!! by F-Demetri Tsanacas on Tuesday, August 17, 2010 - 3:41 am. (1 message)
From: Andy Shevchenko
Date: Tuesday, August 17, 2010 - 3:36 am

The last commits
 37ed19d5cce35a40d3913cf9aa208ce9f60db3d7
 5003bab82d56754b27be01eef24495a02e00039d
have introduced new behaviour of sec2annotation() method. However, the
commentary inside the method was left as before. Let's fix it accordingly.

Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
 scripts/mod/modpost.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 1ec7158..33122ca 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1208,6 +1208,9 @@ static Elf_Sym *find_elf_symbol2(struct elf_info *elf, Elf_Addr addr,
  * .cpuinit.data => __cpudata
  * .memexitconst => __memconst
  * etc.
+ *
+ * The memory of returned value has been allocated on a heap. The user of this
+ * method should free it after usage.
 */
 static char *sec2annotation(const char *s)
 {
@@ -1230,7 +1233,7 @@ static char *sec2annotation(const char *s)
 			strcat(p, "data ");
 		else
 			strcat(p, " ");
-		return r; /* we leak her but we do not care */
+		return r;
 	} else {
 		return strdup("");
 	}
-- 
1.6.3.3

--

From: Michal Marek
Date: Thursday, August 26, 2010 - 4:56 am

Applied, thanks.

Michal
--

Previous thread: [PATCH] scripts/mod/modpost.c: fix commentary accordingly to last changes by Andy Shevchenko on Tuesday, August 17, 2010 - 3:32 am. (1 message)

Next thread: Email Quota Limit Exceeded!!! by F-Demetri Tsanacas on Tuesday, August 17, 2010 - 3:41 am. (1 message)