On 08/26/2010 12:05 AM, Marcelo Tosatti wrote:
quoted text >
>> @@ -3363,7 +3374,7 @@ special_insn:
>> break;
>> case 0xf6 ... 0xf7: /* Grp3 */
>> if (emulate_grp3(ctxt, ops) != X86EMUL_CONTINUE)
>> - goto cannot_emulate;
>> + goto done;
>> break;
> Must assign rc to emulate_grp3() retval.
While there's not much difference between X86EMUL_PROPAGATE_FAULT and
X86EMUL_CONTINUE, it's bad form to break things internally. I'll fix
and repost.
--
error compiling committee.c: too many arguments to function
--
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: [PATCH 3/3] KVM: x86 emulator: trap and propagate #DE ... , Avi Kivity , (Thu Aug 26, 1:23 am)