[PATCH 03/13] cciss: factor out cciss_setintinfo

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Stephen M. Cameron
Date: Thursday, August 26, 2010 - 11:55 am

From: Stephen M. Cameron <scameron@beardog.cce.hp.com>

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
 drivers/block/cciss.c |   66 ++++++++++++++++++++++++-------------------------
 1 files changed, 32 insertions(+), 34 deletions(-)

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 14380c4..5ff5a1d 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1262,6 +1262,37 @@ static int cciss_getintinfo(ctlr_info_t *h, void __user *argp)
 	return 0;
 }
 
+static int cciss_setintinfo(ctlr_info_t *h, void __user *argp)
+{
+	cciss_coalint_struct intinfo;
+	unsigned long flags;
+	int i;
+
+	if (!argp)
+		return -EINVAL;
+	if (!capable(CAP_SYS_ADMIN))
+		return -EPERM;
+	if (copy_from_user(&intinfo, argp, sizeof(intinfo)))
+		return -EFAULT;
+	if ((intinfo.delay == 0) && (intinfo.count == 0))
+		return -EINVAL;
+	spin_lock_irqsave(&h->lock, flags);
+	/* Update the field, and then ring the doorbell */
+	writel(intinfo.delay, &(h->cfgtable->HostWrite.CoalIntDelay));
+	writel(intinfo.count, &(h->cfgtable->HostWrite.CoalIntCount));
+	writel(CFGTBL_ChangeReq, h->vaddr + SA5_DOORBELL);
+
+	for (i = 0; i < MAX_IOCTL_CONFIG_WAIT; i++) {
+		if (!(readl(h->vaddr + SA5_DOORBELL) & CFGTBL_ChangeReq))
+			break;
+		udelay(1000); /* delay and try again */
+	}
+	spin_unlock_irqrestore(&h->lock, flags);
+	if (i >= MAX_IOCTL_CONFIG_WAIT)
+		return -EAGAIN;
+	return 0;
+}
+
 static int cciss_ioctl(struct block_device *bdev, fmode_t mode,
 		       unsigned int cmd, unsigned long arg)
 {
@@ -1278,40 +1309,7 @@ static int cciss_ioctl(struct block_device *bdev, fmode_t mode,
 	case CCISS_GETINTINFO:
 		return cciss_getintinfo(h, argp);
 	case CCISS_SETINTINFO:
-		{
-			cciss_coalint_struct intinfo;
-			unsigned long flags;
-			int i;
-
-			if (!arg)
-				return -EINVAL;
-			if (!capable(CAP_SYS_ADMIN))
-				return -EPERM;
-			if (copy_from_user
-			    (&intinfo, argp, sizeof(cciss_coalint_struct)))
-				return -EFAULT;
-			if ((intinfo.delay == 0) && (intinfo.count == 0))
-				return -EINVAL;
-			spin_lock_irqsave(&h->lock, flags);
-			/* Update the field, and then ring the doorbell */
-			writel(intinfo.delay,
-			       &(h->cfgtable->HostWrite.CoalIntDelay));
-			writel(intinfo.count,
-			       &(h->cfgtable->HostWrite.CoalIntCount));
-			writel(CFGTBL_ChangeReq, h->vaddr + SA5_DOORBELL);
-
-			for (i = 0; i < MAX_IOCTL_CONFIG_WAIT; i++) {
-				if (!(readl(h->vaddr + SA5_DOORBELL)
-				      & CFGTBL_ChangeReq))
-					break;
-				/* delay and try again */
-				udelay(1000);
-			}
-			spin_unlock_irqrestore(&h->lock, flags);
-			if (i >= MAX_IOCTL_CONFIG_WAIT)
-				return -EAGAIN;
-			return 0;
-		}
+		return cciss_setintinfo(h, argp);
 	case CCISS_GETNODENAME:
 		{
 			NodeName_type NodeName;

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/13] cciss: clean up cciss_ioctl(), Stephen M. Cameron, (Thu Aug 26, 11:55 am)
[PATCH 01/13] cciss: factor out cciss_getpciinfo, Stephen M. Cameron, (Thu Aug 26, 11:55 am)
[PATCH 02/13] cciss: factor out cciss_getintinfo, Stephen M. Cameron, (Thu Aug 26, 11:55 am)
[PATCH 03/13] cciss: factor out cciss_setintinfo, Stephen M. Cameron, (Thu Aug 26, 11:55 am)
[PATCH 04/13] cciss: factor out cciss_getnodename, Stephen M. Cameron, (Thu Aug 26, 11:55 am)
[PATCH 05/13] cciss: factor out cciss_setnodename, Stephen M. Cameron, (Thu Aug 26, 11:55 am)
[PATCH 06/13] cciss: factor out cciss_getheartbeat, Stephen M. Cameron, (Thu Aug 26, 11:55 am)
[PATCH 07/13] cciss: factor out cciss_getbustypes, Stephen M. Cameron, (Thu Aug 26, 11:56 am)
[PATCH 08/13] cciss: factor out cciss_getfirmver, Stephen M. Cameron, (Thu Aug 26, 11:56 am)
[PATCH 09/13] cciss: factor out cciss_getdrivver, Stephen M. Cameron, (Thu Aug 26, 11:56 am)
[PATCH 10/13] cciss: factor out cciss_getluninfo, Stephen M. Cameron, (Thu Aug 26, 11:56 am)
[PATCH 11/13] cciss: factor out cciss_passthru, Stephen M. Cameron, (Thu Aug 26, 11:56 am)
[PATCH 12/13] cciss: factor out cciss_big_passthru, Stephen M. Cameron, (Thu Aug 26, 11:56 am)
[PATCH 13/13] cciss: remove some superfluous tests from cc ..., Stephen M. Cameron, (Thu Aug 26, 11:56 am)
Re: [PATCH 00/13] cciss: clean up cciss_ioctl(), Jens Axboe, (Fri Sep 10, 3:13 am)