Re: [PATCH -v3] perf, x86: try to handle unknown nmis with running perfctrs | KernelTrap

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with running perfctrs

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Yinghai Lu

Subject: Re: [PATCH -v3] perf, x86: try to handle unknown nmis with running perfctrs

Date: Friday, August 27, 2010 - 12:00 pm

On 08/27/2010 11:57 AM, Don Zickus wrote:
quoted text> On Fri, Aug 27, 2010 at 10:10:38AM +0200, Robert Richter wrote:
>>>  
>>>  	inc_irq_stat(apic_perf_irqs);
>>>  	ack = status;
>>> +	intel_pmu_ack_status(ack);
>>
>> I would slightly change the patch:
>>
>> There is no need for the ack variable anymore, you could directly work
>> with the status.
>>
>> I would call intel_pmu_ack_status() as close as possible after the
>> intel_pmu_get_status(), which is after 'again:'.
>>
> 
> Here is another version of the patch, which uses Robert's suggestion of
> removing the ack variable

Can you resend all three updated patches?

Thanks

Yinghai
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Fri Aug 20, 8:05 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Ingo Molnar, (Fri Aug 20, 8:25 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Fri Aug 20, 4:31 pm)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Ingo Molnar, (Mon Aug 23, 1:53 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Tue Aug 24, 9:22 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Tue Aug 24, 10:09 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Tue Aug 24, 10:15 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Tue Aug 24, 10:20 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Tue Aug 24, 10:21 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Tue Aug 24, 10:28 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Tue Aug 24, 11:46 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Tue Aug 24, 11:54 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Tue Aug 24, 12:52 pm)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Tue Aug 24, 1:27 pm)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Tue Aug 24, 1:40 pm)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Wed Aug 25, 2:48 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Wed Aug 25, 3:20 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Ingo Molnar, (Wed Aug 25, 3:41 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Ingo Molnar, (Wed Aug 25, 4:00 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Wed Aug 25, 4:02 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Ingo Molnar, (Wed Aug 25, 4:19 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Wed Aug 25, 1:11 pm)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Wed Aug 25, 1:24 pm)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Wed Aug 25, 2:20 pm)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Wed Aug 25, 2:36 pm)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Frederic Weisbecker, (Wed Aug 25, 4:52 pm)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Thu Aug 26, 2:00 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Thu Aug 26, 2:11 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Thu Aug 26, 2:18 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Thu Aug 26, 7:31 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Thu Aug 26, 8:22 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Thu Aug 26, 8:34 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Thu Aug 26, 9:40 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Cyrill Gorcunov, (Thu Aug 26, 11:02 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Thu Aug 26, 2:14 pm)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Fri Aug 27, 12:51 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Fri Aug 27, 12:57 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Fri Aug 27, 1:10 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Peter Zijlstra, (Fri Aug 27, 1:11 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Fri Aug 27, 1:31 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Fri Aug 27, 6:39 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Fri Aug 27, 6:44 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Fri Aug 27, 7:05 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Fri Aug 27, 8:05 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Fri Aug 27, 8:48 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Don Zickus, (Fri Aug 27, 11:57 am)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Yinghai Lu, (Fri Aug 27, 12:00 pm)

Re: [PATCH -v3] perf, x86: try to handle unknown nmis with ..., Robert Richter, (Fri Aug 27, 12:33 pm)

Navigation

Popular discussions


linux-kernel:
Greg KH	Og dreams of kernels
Jens Axboe	[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann	Re: finding your own dead "CONFIG_" variables
Mark Brown	[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds	[LGUEST] Look in object dir for .config
git:
Brian Downing	Re: Git in a Nutshell guide
John Benes	Re: master has some toys
Matthias Lederhofer	[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian	[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano	Re: Rss produced by git is not valid xml?
git-commits-head:
Linux Kernel Mailing List	iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List