[PATCH v2 4/7] swap: Change remove_from_page_cache

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Minchan Kim
Date: Sunday, January 2, 2011 - 8:44 am

This patch series changes remove_from_page_cache's page ref counting
rule. Page cache ref count is decreased in delete_from_page_cache.
So we don't need decreasing page reference by caller.

Acked-by:Hugh Dickins <hughd@google.com>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
---
 mm/shmem.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index fa9acc9..079cced 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1081,7 +1081,7 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc)
 	shmem_recalc_inode(inode);
 
 	if (swap.val && add_to_swap_cache(page, swap, GFP_ATOMIC) == 0) {
-		remove_from_page_cache(page);
+		delete_from_page_cache(page);
 		shmem_swp_set(info, entry, swap.val);
 		shmem_swp_unmap(entry);
 		if (list_empty(&info->swaplist))
@@ -1091,7 +1091,6 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc)
 		spin_unlock(&info->lock);
 		swap_shmem_alloc(swap);
 		BUG_ON(page_mapped(page));
-		page_cache_release(page);	/* pagecache ref */
 		swap_writepage(page, wbc);
 		if (inode) {
 			mutex_lock(&shmem_swaplist_mutex);
-- 
1.7.0.4

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH v2 1/7] Introduce delete_from_page_cache, Minchan Kim, (Sun Jan 2, 8:44 am)
[PATCH v2 2/7] fuse: Change remove_from_page_cache, Minchan Kim, (Sun Jan 2, 8:44 am)
[PATCH v2 3/7] tlbfs: Change remove_from_page_cache, Minchan Kim, (Sun Jan 2, 8:44 am)
[PATCH v2 4/7] swap: Change remove_from_page_cache, Minchan Kim, (Sun Jan 2, 8:44 am)
[PATCH v2 6/7] Good bye remove_from_page_cache, Minchan Kim, (Sun Jan 2, 8:44 am)
[PATCH v2 7/7] Change __remove_from_page_cache, Minchan Kim, (Sun Jan 2, 8:44 am)
Re: [PATCH v2 6/7] Good bye remove_from_page_cache, KAMEZAWA Hiroyuki, (Mon Jan 3, 6:44 pm)
Re: [PATCH v2 7/7] Change __remove_from_page_cache, KAMEZAWA Hiroyuki, (Mon Jan 3, 6:45 pm)