Home » Mailing list archives » linux-kernel » 2011 » January » 4

Re: [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret

Previous thread: by gavin willock on Monday, January 3, 2011 - 8:52 am. (1 message)

Next thread: Re: Loss of PAT-WC after resume on i5 by H. Peter Anvin on Monday, January 3, 2011 - 9:01 am. (3 messages)
[view original message]
From: Axel Lin
Subject: [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret
Date: Monday, January 3, 2011 - 8:57 am

Otherwise, we will not return error if write to MC13892_SWITCHERS5 failed.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/regulator/mc13892-regulator.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
index 16a0532..1b8f739 100644
--- a/drivers/regulator/mc13892-regulator.c
+++ b/drivers/regulator/mc13892-regulator.c
@@ -550,7 +550,7 @@ static int __devinit mc13892_regulator_probe(struct platform_device *pdev)
 		if (ret)
 			goto err_free;
 
-		mc13xxx_reg_rmw(mc13892, MC13892_SWITCHERS5,
+		ret = mc13xxx_reg_rmw(mc13892, MC13892_SWITCHERS5,
 			MC13892_SWITCHERS5_SW3MODE_M |
 			MC13892_SWITCHERS5_SW4MODE_M,
 			MC13892_SWITCHERS5_SW3MODE_AUTO |
-- 
1.7.0.4



--


[ message continues ]
[view original message]
From: Mark Brown
Subject: Re: [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret
Date: Monday, January 3, 2011 - 8:59 am

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
--


[ message continues ]
[view original message]
From: Yong Shen
Subject: Re: [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret
Date: Monday, January 3, 2011 - 7:02 pm

Acked-by: Yong Shen <yong.shen@linaro.org>

--


[ message continues ]
[view original message]
From: Liam Girdwood
Subject: Re: [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret
Date: Tuesday, January 4, 2011 - 1:51 pm

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--


[ message continues ]
Previous thread: by gavin willock on Monday, January 3, 2011 - 8:52 am. (1 message)

Next thread: Re: Loss of PAT-WC after resume on i5 by H. Peter Anvin on Monday, January 3, 2011 - 9:01 am. (3 messages)