Home » Mailing list archives » linux-kernel » 2011 » January » 4

Re: [PATCH] crypto: dont return PTR_ERR() of wrong pointer

Previous thread: libertas: down_interruptible() can return -EINTR, not EINTR by roel kluin on Friday, December 31, 2010 - 8:05 am. (1 message)

Next thread: [PATCH] regulator: missing index in PTR_ERR() in isl6271a_probe() by roel kluin on Friday, December 31, 2010 - 8:26 am. (3 messages)
[view original message]
From: roel kluin
Subject: [PATCH] crypto: dont return PTR_ERR() of wrong pointer
Date: Friday, December 31, 2010 - 8:21 am

Fix a PTR_ERR() return of the wrong pointer

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
 drivers/crypto/mv_cesa.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
index 7d279e5..c99305a 100644
--- a/drivers/crypto/mv_cesa.c
+++ b/drivers/crypto/mv_cesa.c
@@ -857,7 +857,7 @@ static int mv_cra_hash_init(struct crypto_tfm *tfm, const char *base_hash_name,
 			printk(KERN_WARNING MV_CESA
 			       "Base driver '%s' could not be loaded!\n",
 			       base_hash_name);
-			err = PTR_ERR(fallback_tfm);
+			err = PTR_ERR(base_hash);
 			goto err_bad_base;
 		}
 	}
--


[ message continues ]
[view original message]
From: Herbert Xu
Subject: Re: [PATCH] crypto: dont return PTR_ERR() of wrong pointer
Date: Monday, January 3, 2011 - 9:37 pm

Patch applied.  Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--


[ message continues ]
Previous thread: libertas: down_interruptible() can return -EINTR, not EINTR by roel kluin on Friday, December 31, 2010 - 8:05 am. (1 message)

Next thread: [PATCH] regulator: missing index in PTR_ERR() in isl6271a_probe() by roel kluin on Friday, December 31, 2010 - 8:26 am. (3 messages)