Home » Mailing list archives » linux-kernel » 2011 » January » 4

[tip:perf/core] perf tools: Refactor cpumap to hold nr and the map

Previous thread: [tip:perf/core] perf evsel: Introduce per cpu and per thread open helpers by tip-bot for Arnaldo Carvalho de Melo on Tuesday, January 4, 2011 - 1:23 am. (1 message)

Next thread: [tip:perf/core] perf tools: Refactor all_tids to hold nr and the map by tip-bot for Arnaldo Carvalho de Melo on Tuesday, January 4, 2011 - 1:24 am. (1 message)
[view original message]
From: tip-bot for Arnaldo Carvalho de Melo
Subject: [tip:perf/core] perf tools: Refactor cpumap to hold nr and the map
Date: Tuesday, January 4, 2011 - 1:24 am

Commit-ID:  60d567e2d9187379d642f6aba7c8a52b3fd5d261
Gitweb:     http://git.kernel.org/tip/60d567e2d9187379d642f6aba7c8a52b3fd5d261
Author:     Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Mon, 3 Jan 2011 17:49:48 -0200
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 4 Jan 2011 00:23:55 -0200

perf tools: Refactor cpumap to hold nr and the map

So that later, we can pass the cpu_map instance instead of (nr_cpus, cpu_map)
for things like perf_evsel__open and friends.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-record.c |   14 +++---
 tools/perf/builtin-stat.c   |   36 ++++++------
 tools/perf/builtin-top.c    |   22 ++++----
 tools/perf/util/cpumap.c    |  123 +++++++++++++++++++++++++++++++++----------
 tools/perf/util/cpumap.h    |   10 +++-
 5 files changed, 138 insertions(+), 67 deletions(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 052de17..220e6e7 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -39,7 +39,7 @@ static u64			user_interval			= ULLONG_MAX;
 static u64			default_interval		=      0;
 static u64			sample_type;
 
-static int			nr_cpus				=      0;
+static struct cpu_map		*cpus;
 static unsigned int		page_size;
 static unsigned int		mmap_pages			=    128;
 static unsigned int		user_freq 			= UINT_MAX;
@@ -670,8 +670,8 @@ static int __cmd_record(int argc, const char **argv)
 	if (!system_wide && no_inherit && !cpu_list) {
 		open_counters(-1);
 	} else {
-		for (i = 0; i < nr_cpus; i++)
-			open_counters(cpumap[i]);
+		for (i = 0; i < cpus->nr; i++)
+			open_counters(cpus->map[i]);
 	}
 
 ...
[ message continues ]
Previous thread: [tip:perf/core] perf evsel: Introduce per cpu and per thread open helpers by tip-bot for Arnaldo Carvalho de Melo on Tuesday, January 4, 2011 - 1:23 am. (1 message)

Next thread: [tip:perf/core] perf tools: Refactor all_tids to hold nr and the map by tip-bot for Arnaldo Carvalho de Melo on Tuesday, January 4, 2011 - 1:24 am. (1 message)