Re: [PATCH 1/2] apic: Move hypervisor detection of x2apic to hypervisor.h

Previous thread: [PATCH 2/2 v2] xen: HVM X2APIC support by Sheng Yang on Monday, December 20, 2010 - 11:18 pm. (1 message)

Next thread: linux-next: build warnings after merge of the tty tree by Stephen Rothwell on Tuesday, December 21, 2010 - 12:11 am. (2 messages)
From: Sheng Yang
Date: Monday, December 20, 2010 - 11:18 pm

Then we can reuse it for Xen later.

Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
 arch/x86/include/asm/hypervisor.h |    9 +++++++++
 arch/x86/kernel/apic/apic.c       |    5 +++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/hypervisor.h b/arch/x86/include/asm/hypervisor.h
index ff2546c..0c6f7af 100644
--- a/arch/x86/include/asm/hypervisor.h
+++ b/arch/x86/include/asm/hypervisor.h
@@ -20,6 +20,8 @@
 #ifndef _ASM_X86_HYPERVISOR_H
 #define _ASM_X86_HYPERVISOR_H
 
+#include <asm/kvm_para.h>
+
 extern void init_hypervisor(struct cpuinfo_x86 *c);
 extern void init_hypervisor_platform(void);
 
@@ -47,4 +49,11 @@ extern const struct hypervisor_x86 x86_hyper_vmware;
 extern const struct hypervisor_x86 x86_hyper_ms_hyperv;
 extern const struct hypervisor_x86 x86_hyper_xen_hvm;
 
+static inline bool hypervisor_x2apic_available(void)
+{
+	if (kvm_para_available())
+		return true;
+	return false;
+}
+
 #endif
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 3f838d5..8408f2d 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -50,8 +50,8 @@
 #include <asm/mtrr.h>
 #include <asm/smp.h>
 #include <asm/mce.h>
-#include <asm/kvm_para.h>
 #include <asm/tsc.h>
+#include <asm/hypervisor.h>
 
 unsigned int num_processors;
 
@@ -1476,7 +1476,8 @@ void __init enable_IR_x2apic(void)
 		/* IR is required if there is APIC ID > 255 even when running
 		 * under KVM
 		 */
-		if (max_physical_apicid > 255 || !kvm_para_available())
+		if (max_physical_apicid > 255 ||
+		    !hypervisor_x2apic_available())
 			goto nox2apic;
 		/*
 		 * without IR all CPUs can be addressed by IOAPIC/MSI
-- 
1.7.0.1

--

From: Jeremy Fitzhardinge
Date: Tuesday, December 21, 2010 - 10:15 am

You should probably get someone kvm-ish to ack this too.


--

From: Avi Kivity
Date: Tuesday, December 21, 2010 - 11:15 am

Looks good to me.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--

From: Sheng Yang
Date: Thursday, December 30, 2010 - 7:05 pm

Ingo/Peter?

--
regards
Yang, Sheng
--

From: Sheng Yang
Date: Tuesday, January 4, 2011 - 1:57 am

Ingo,

Comments?

--
regards
Yang, Sheng
--

From: Ingo Molnar
Date: Tuesday, January 4, 2011 - 2:24 am

Acked-by: Ingo Molnar <mingo@elte.hu>

I suspect these patches want to be carried in the Xen tree, right? Shouldnt cause 
too bad conflicts, as long as the Xen tree is pushed after the x86 tree in the merge 
window.

Thanks,

	Ingo
--

Previous thread: [PATCH 2/2 v2] xen: HVM X2APIC support by Sheng Yang on Monday, December 20, 2010 - 11:18 pm. (1 message)

Next thread: linux-next: build warnings after merge of the tty tree by Stephen Rothwell on Tuesday, December 21, 2010 - 12:11 am. (2 messages)