Home » Mailing list archives » linux-kernel » 2011 » January » 4

[tip:sched/core] sched, autogroup: Fix reference leak

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: tip-bot for Mike Galbraith
Subject: [tip:sched/core] sched, autogroup: Fix reference leak
Date: Tuesday, January 4, 2011 - 7:19 am

Commit-ID:  101e5f77bf35679809586e250b6c62193d2ed179
Gitweb:     http://git.kernel.org/tip/101e5f77bf35679809586e250b6c62193d2ed179
Author:     Mike Galbraith <efault@gmx.de>
AuthorDate: Fri, 31 Dec 2010 09:32:30 +0100
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 4 Jan 2011 15:10:36 +0100

sched, autogroup: Fix reference leak

The cgroup exit mess also uncovered a struct autogroup reference leak.
copy_process() was simply freeing vs putting the signal_struct,
stranding a reference.

Signed-off-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Oleg Nesterov <oleg@redhat.com>
LKML-Reference: <1293784350.6839.2.camel@marge.simson.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/fork.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index b6f2475..0672444 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1317,7 +1317,7 @@ bad_fork_cleanup_mm:
 	}
 bad_fork_cleanup_signal:
 	if (!(clone_flags & CLONE_THREAD))
-		free_signal_struct(p->signal);
+		put_signal_struct(p->signal);
 bad_fork_cleanup_sighand:
 	__cleanup_sighand(p->sighand);
 bad_fork_cleanup_fs:
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Tue Jun 29, 3:43 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., shenghui, (Tue Jun 29, 4:24 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Tue Jun 29, 4:35 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Miklos Vajna, (Sat Dec 18, 7:03 pm)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Miklos Vajna, (Tue Dec 21, 5:22 pm)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Wed Dec 22, 1:29 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Wed Dec 22, 1:41 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Mike Galbraith, (Wed Dec 22, 1:41 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Wed Dec 22, 2:07 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Miklos Vajna, (Wed Dec 22, 6:31 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Wed Dec 22, 7:00 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Wed Dec 22, 7:11 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Miklos Vajna, (Wed Dec 22, 8:14 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Wed Dec 22, 10:08 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Ingo Molnar, (Wed Dec 22, 10:16 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Miklos Vajna, (Wed Dec 22, 2:11 pm)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Miklos Vajna, (Wed Dec 22, 4:39 pm)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Yong Zhang, (Wed Dec 22, 7:08 pm)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Thu Dec 23, 5:12 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Thu Dec 23, 5:33 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Thu Dec 23, 11:24 am)
[PATCH] sched, cgroup: Use exit hook to avoid use-after-fr ..., Peter Zijlstra, (Fri Dec 24, 8:59 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Miklos Vajna, (Fri Dec 24, 9:40 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Mike Galbraith, (Fri Dec 24, 9:48 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Peter Zijlstra, (Fri Dec 24, 10:07 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Mike Galbraith, (Fri Dec 24, 10:24 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Balbir Singh, (Sat Dec 25, 10:55 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Paul Menage, (Sat Dec 25, 1:59 pm)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Ingo Molnar, (Wed Dec 29, 8:25 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Miklos Vajna, (Wed Dec 29, 4:07 pm)
[PATCH] Re: [PATCH] sched, cgroup: Use exit hook to avoid ..., Mike Galbraith, (Fri Dec 31, 1:32 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Mike Galbraith, (Fri Dec 31, 3:04 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Peter Zijlstra, (Mon Jan 3, 12:06 am)
Re: [PATCH] Re: [PATCH] sched, cgroup: Use exit hook to av ..., Peter Zijlstra, (Mon Jan 3, 1:21 am)
[tip:sched/core] sched, autogroup: Fix reference leak, tip-bot for Mike Gal ..., (Tue Jan 4, 7:19 am)
Re: [tip:sched/core] sched, autogroup: Fix reference leak, Oleg Nesterov, (Tue Jan 4, 7:57 am)
Re: [tip:sched/core] sched, autogroup: Fix reference leak, Mike Galbraith, (Tue Jan 4, 12:06 pm)