netfilter 24/29: nf_conntrack_proto_sctp: avoid bogus warning

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Patrick McHardy
Date: Thursday, November 27, 2008 - 9:15 am

commit 328bd8997dbb7184d5389e45c642af44ae6e9043
Author: Patrick McHardy <kaber@trash.net>
Date:   Mon Nov 24 13:44:55 2008 +0100

    netfilter: nf_conntrack_proto_sctp: avoid bogus warning
    
    net/netfilter/nf_conntrack_proto_sctp.c: In function 'sctp_packet':
    net/netfilter/nf_conntrack_proto_sctp.c:376: warning: array subscript is above array bounds
    
    gcc doesn't realize that do_basic_checks() guarantees that there is
    at least one valid chunk and thus new_state is never SCTP_CONNTRACK_MAX
    after the loop. Initialize to SCTP_CONNTRACK_NONE to avoid the warning.
    
    Based on patch by Wu Fengguang <wfg@linux.intel.com>
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>

diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c
index c2bd457..74e0379 100644
--- a/net/netfilter/nf_conntrack_proto_sctp.c
+++ b/net/netfilter/nf_conntrack_proto_sctp.c
@@ -317,7 +317,7 @@ static int sctp_packet(struct nf_conn *ct,
 		goto out;
 	}
 
-	old_state = new_state = SCTP_CONNTRACK_MAX;
+	old_state = new_state = SCTP_CONNTRACK_NONE;
 	write_lock_bh(&sctp_lock);
 	for_each_sctp_chunk (skb, sch, _sch, offset, dataoff, count) {
 		/* Special cases of Verification tag check (Sec 8.5.1) */
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
netfilter 00/29: Netfilter Update, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 02/29: netns-aware ipt_addrtype, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 03/29: arptable_filter: merge forward hook, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 04/29: netns ebtables: part 1, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 05/29: netns ebtables: part 2, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 07/29: netns ebtables: ebtable_broute in netns, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 08/29: netns ebtables: ebtable_filter in netns, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 09/29: netns ebtables: ebtable_nat in netns, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 11/29: nf_nat: remove warn_if_extra_mangle, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 20/29: xt_recent: don't save proc dirs, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 22/29: nf_conntrack_proto_gre: spread __exit, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 23/29: ip{,6}t_policy.h should include xp_policy.h, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 24/29: nf_conntrack_proto_sctp: avoid bogus warning, Patrick McHardy, (Thu Nov 27, 9:15 am)
netfilter 26/29: nfmark routing in OUTPUT, mangle, NFQUEUE, Patrick McHardy, (Thu Nov 27, 9:15 am)
Re: netfilter 00/29: Netfilter Update, Patrick McHardy, (Thu Nov 27, 9:16 am)
Re: netfilter 07/29: netns ebtables: ebtable_broute in netns, Jan Engelhardt, (Thu Nov 27, 11:25 am)
Re: netfilter 07/29: netns ebtables: ebtable_broute in netns, Patrick McHardy, (Thu Nov 27, 11:28 am)
Re: netfilter 11/29: nf_nat: remove warn_if_extra_mangle, Jan Engelhardt, (Thu Nov 27, 11:28 am)
Re: netfilter 07/29: netns ebtables: ebtable_broute in netns, Alexey Dobriyan, (Fri Nov 28, 1:02 am)
Re: netfilter 00/29: Netfilter Update, David Miller, (Fri Nov 28, 4:03 am)