A while ago Andy Fleming had replied to one of my patches expressing an interest in implementing WOL (which I expanded to mean "more control of the lifetime of the phy") within the phylib. I responded that there were two problems with that approach. Very briefly, the problems were that the phylib did not have enough information available to determine what power state to put the phy into (think management firmware), and that turning off the phy might interfere with the normal operation of some MAC registers. I'm sorry that thread died so abruptly. My concerns remain though. At the time the phy is initially probed, there is no way to gather enough information to determine whether or not it is safe to power down the phy. The earliest such information can be communicated is through the flags parameter of the phy_connect() function. I can't speak for the other uses of the phylib, but for tg3 it makes a lot of sense to place phy power management in the hands of the driver that controls it. If you agree, can we devise a way to bypass the suspend callback? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
