[PATCH 07/40] debugfs: add helpers for exporting a size_t simple value

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Inaky Perez-Gonzalez
Date: Friday, December 5, 2008 - 11:55 am

In the same spirit as debugfs_create_*(), introduce helpers for
exporting size_t values over debugfs.

The only trick done is that the format verifier is kept at %llu
instead of %zu; otherwise type warnings would pop up:

format ‘%zu’ expects type ‘size_t’, but argument 2 has type ‘long long unsigned int’

There is no real way to fix this one--however, we can consider %llu
and %zu to be compatible if we consider that we are using the same for
validating in debugfs_create_{x,u}{8,16,32}().

Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Cc: Greg KH <greg@kroah.com>
---
 fs/debugfs/file.c       |   32 ++++++++++++++++++++++++++++++++
 include/linux/debugfs.h |    2 ++
 2 files changed, 34 insertions(+), 0 deletions(-)

diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
index 159a5ef..33a9012 100644
--- a/fs/debugfs/file.c
+++ b/fs/debugfs/file.c
@@ -294,6 +294,38 @@ struct dentry *debugfs_create_x32(const char *name, mode_t mode,
 }
 EXPORT_SYMBOL_GPL(debugfs_create_x32);
 
+
+static int debugfs_size_t_set(void *data, u64 val)
+{
+	*(size_t *)data = val;
+	return 0;
+}
+static int debugfs_size_t_get(void *data, u64 *val)
+{
+	*val = *(size_t *)data;
+	return 0;
+}
+DEFINE_SIMPLE_ATTRIBUTE(fops_size_t, debugfs_size_t_get, debugfs_size_t_set,
+			"%llu\n");	/* %llu and %zu are more or less the same */
+
+/**
+ * debugfs_create_size_t - create a debugfs file that is used to read and write an size_t value
+ * @name: a pointer to a string containing the name of the file to create.
+ * @mode: the permission that the file should have
+ * @parent: a pointer to the parent dentry for this file.  This should be a
+ *          directory dentry if set.  If this parameter is %NULL, then the
+ *          file will be created in the root of the debugfs filesystem.
+ * @value: a pointer to the variable that the file should read to and write
+ *         from.
+ */
+struct dentry *debugfs_create_size_t(const char *name, mode_t mode,
+				     struct dentry *parent, size_t *value)
+{
+	return debugfs_create_file(name, mode, parent, value, &fops_size_t);
+}
+EXPORT_SYMBOL_GPL(debugfs_create_size_t);
+
+
 static ssize_t read_file_bool(struct file *file, char __user *user_buf,
 			      size_t count, loff_t *ppos)
 {
diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
index e1a6c04..23936b1 100644
--- a/include/linux/debugfs.h
+++ b/include/linux/debugfs.h
@@ -63,6 +63,8 @@ struct dentry *debugfs_create_x16(const char *name, mode_t mode,
 				  struct dentry *parent, u16 *value);
 struct dentry *debugfs_create_x32(const char *name, mode_t mode,
 				  struct dentry *parent, u32 *value);
+struct dentry *debugfs_create_size_t(const char *name, mode_t mode,
+				     struct dentry *parent, size_t *value);
 struct dentry *debugfs_create_bool(const char *name, mode_t mode,
 				  struct dentry *parent, u32 *value);
 
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/40] merge request for WiMAX kernel stack and i24 ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:54 am)
[PATCH 01/40] wimax: documentation for the stack, Inaky Perez-Gonzalez, (Fri Dec 5, 11:54 am)
[PATCH 02/40] wimax: declarations for the in-kernel WiMAX API, Inaky Perez-Gonzalez, (Fri Dec 5, 11:54 am)
[PATCH 03/40] wimax: constants and definitions to interact ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:54 am)
[PATCH 04/40] wimax: internal API for the kernel space WiM ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:54 am)
[PATCH 05/40] wimax: debug macros and debug settings for t ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:54 am)
[PATCH 06/40] genetlink: export genl_unregister_mc_group(), Inaky Perez-Gonzalez, (Fri Dec 5, 11:54 am)
[PATCH 07/40] debugfs: add helpers for exporting a size_t ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 08/40] wimax: generic WiMAX device management (regi ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 09/40] wimax: Mappping of generic netlink family ID ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 10/40] wimax: Generic messaging interface between u ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 11/40] wimax: RF-kill framework integration, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 12/40] wimax: API call to reset a WiMAX device, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 13/40] wimax: debugfs controls, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 14/40] wimax: Makefile, Kconfig and docbook linkage ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 15/40] i2400m: documentation and instructions for usage, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 16/40] i2400m: host-to-device protocol definitions, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 17/40] i2400m: core driver definitions and API, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 18/40] i2400m: Generic probe/disconnect, reset and ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 19/40] i2400m: linkage to the networking stack, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 20/40] i2400m: debugfs controls, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 21/40] i2400m: rfkill integration with the WiMAX stack, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 22/40] i2400m: firmware loading and bootrom initial ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 23/40] i2400m: handling of the data/control recepti ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 24/40] i2400m: handling of the data/control transmi ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 25/40] i2400m: various functions for device management, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 26/40] i2400m/USB: header for the USB bus driver, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 27/40] i2400m/USB: error density tracking, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 28/40] i2400m/USB: main probe/disconnect and backen ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 29/40] i2400m/USB: firmware upload backend, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 30/40] i2400m/USB: handling of notifications from t ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 31/40] i2400m/USB: read transactions from the USB d ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 32/40] i2400m/USB: write transactions to the USB device, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 33/40] i2400m/SDIO: header for the SDIO subdriver, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 34/40] i2400m/SDIO: main probe/disconnect and backe ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 35/40] i2400m/SDIO: firmware upload backend, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 36/40] i2400m/SDIO: read transactions from the SDIO ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 37/40] i2400m/SDIO: write transactions to the SDIO ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 38/40] i2400m: Makefile and Kconfig, Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 39/40] wimax: export linux/wimax.h and linux/wimax/ ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
[PATCH 40/40] wimax/i2400m: add CREDITS and MAINTAINERS en ..., Inaky Perez-Gonzalez, (Fri Dec 5, 11:55 am)
Re: [PATCH 02/40] wimax: declarations for the in-kernel Wi ..., Inaky Perez-Gonzalez, (Sat Dec 6, 6:04 pm)