Re: [patch 04/13] 8390: Split 8390 support into a pausing and a non pausing driver core

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Alan Cox

Subject: Re: [patch 04/13] 8390: Split 8390 support into a pausing and a non pausing driver core

Date: Monday, June 9, 2008 - 4:52 pm

On Mon, 09 Jun 2008 16:33:49 -0700
akpm@linux-foundation.org wrote:

quoted text> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> 
> Only a few ISA controllers need the pausing version of the 8390 core
> while PCMCIA, later ISA and PCI do not. More importantly the ISA delays
> can break non ISA boxes so we must use a different build of 8390.c for
> the two sets of controllers.
> 
> No changes since last time as all the points of concerns raised proved to
> be invalid
> 
> [randy.dunlap@oracle.com: ne2 (MCA) needs both 8390.o and 8390p.o functions]

ne2 does not need both, it hasn't needed both and its completely invalid
to have both in one driver. Please drop Randy's change out and fix the
actual typo instead.

Alan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[patch 04/13] 8390: Split 8390 support into a pausing and ..., akpm, (Mon Jun 9, 4:33 pm)

[patch 09/13] smc911x: pass along private data and use iomem, akpm, (Mon Jun 9, 4:33 pm)

Re: [patch 04/13] 8390: Split 8390 support into a pausing ..., Alan Cox, (Mon Jun 9, 4:52 pm)

Re: [patch 04/13] 8390: Split 8390 support into a pausing ..., Alan Cox, (Mon Jun 9, 5:13 pm)

Re: [patch 04/13] 8390: Split 8390 support into a pausing ..., Andrew Morton, (Mon Jun 9, 5:15 pm)

Re: [patch 04/13] 8390: Split 8390 support into a pausing ..., Andrew Morton, (Mon Jun 9, 5:19 pm)

Re: [patch 04/13] 8390: Split 8390 support into a pausing ..., Alan Cox, (Tue Jun 10, 1:55 am)

Re: [patch 04/13] 8390: Split 8390 support into a pausing ..., Alan Cox, (Tue Jun 10, 3:20 am)

Re: [patch 04/13] 8390: Split 8390 support into a pausing ..., Randy Dunlap, (Wed Jun 11, 11:25 am)

Re: [patch 04/13] 8390: Split 8390 support into a pausing ..., Alan Cox, (Thu Jun 12, 2:10 pm)

Re: [patch 04/13] 8390: Split 8390 support into a pausing ..., Randy Dunlap, (Thu Jun 12, 2:37 pm)