Re: [RFC][PATCH 1/3] net: per skb control messages

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Thursday, July 24, 2008 - 1:28 pm

From: Octavian Purdila <opurdila@ixiacom.com>
Date: Thu, 24 Jul 2008 19:22:57 +0300


Adding new fields to struct sk_buff that take up space is generally
not allowed unless the new field adds substantially to the benefit of
a large group of users of Linus.

I don't think that applied here for this hw-tstamps stuff.

And yes, this is even with the config option protection, because every
distribution is going to turn all the options on, which makes them
essentially pointless from a sk_buff overhead perspective.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH 0/3] net: per skb control messages, Octavian Purdila, (Wed Jul 23, 3:01 pm)
[RFC][PATCH 1/3] net: per skb control messages, Octavian Purdila, (Wed Jul 23, 3:01 pm)
[RFC][PATCH 2/3] ip: support for SOL_SKB control messages ..., Octavian Purdila, (Wed Jul 23, 3:01 pm)
[RFC][PATCH 3/3] net: add SKB_SOL control messages, Octavian Purdila, (Wed Jul 23, 3:01 pm)
Re: [RFC][PATCH 1/3] net: per skb control messages, Herbert Xu, (Thu Jul 24, 5:46 am)
Re: [RFC][PATCH 1/3] net: per skb control messages, Octavian Purdila, (Thu Jul 24, 6:34 am)
Re: [RFC][PATCH 1/3] net: per skb control messages, Herbert Xu, (Thu Jul 24, 8:01 am)
Re: [RFC][PATCH 1/3] net: per skb control messages, Octavian Purdila, (Thu Jul 24, 9:22 am)
Re: [RFC][PATCH 1/3] net: per skb control messages, David Miller, (Thu Jul 24, 1:28 pm)
Re: [RFC][PATCH 1/3] net: per skb control messages, Octavian Purdila, (Thu Jul 24, 2:49 pm)
Re: [RFC][PATCH 1/3] net: per skb control messages, David Miller, (Thu Jul 24, 2:56 pm)
Re: [RFC][PATCH 1/3] net: per skb control messages, Stephen Hemminger, (Thu Jul 24, 2:58 pm)
Re: [RFC][PATCH 1/3] net: per skb control messages, Octavian Purdila, (Thu Jul 24, 3:12 pm)
Re: [RFC][PATCH 1/3] net: per skb control messages, David Miller, (Thu Jul 24, 3:17 pm)
Re: [RFC][PATCH 1/3] net: per skb control messages, Octavian Purdila, (Thu Jul 24, 3:35 pm)
Re: [RFC][PATCH 1/3] net: per skb control messages, Stephen Hemminger, (Thu Jul 24, 4:05 pm)
Re: [RFC][PATCH 1/3] net: per skb control messages, Octavian Purdila, (Thu Jul 24, 4:14 pm)
Re: [RFC][PATCH 1/3] net: per skb control messages, David Miller, (Thu Jul 24, 4:18 pm)
Re: [RFC][PATCH 1/3] net: per skb control messages, Octavian Purdila, (Thu Jul 24, 4:26 pm)