From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Fri, 25 Jul 2008 22:15:33 -0400

quoted text
> Gerrit Renker wrote:
> >  * icmp_unreach() in net/ipv4/icmp.c already has this test:
> > 
> > 	/* Checkin full IP header plus 8 bytes of protocol to
> > 	 * avoid additional coding at protocol handlers.
> > 	 */
> >         if (!pskb_may_pull(skb, iph->ihl * 4 + 8))
> >                 goto out;

I just noticed that this won't bump the ICMP MIB counter.

The ICMP code will only bump the counter if the IP header isn't there,
or has a bogus header length.

But it is clear in the callers that the intention is (or was) to bump
the counter if the 8 bytes of post IP header bits are not there.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html