Re: [PATCH -tip] in6.h: extern's make no sense in userspace

view
thread

Previous thread: Re: sendfile()? Re: SO_LINGER dead: I get an immediate RST on 2.6.24? by Herbert Xu on Monday, January 12, 2009 - 11:32 pm. (12 messages)

Next thread: [PATCH]IPv6:remove duplicate check of optlen when setsockopt with IPV6_PKTINFO option by Yang Hongyang on Tuesday, January 13, 2009 - 12:35 am. (18 messages)

[view original message]

From: Jaswinder Singh Rajput

Subject: [PATCH -tip] in6.h: extern's make no sense in userspace

Date: Monday, January 12, 2009 - 11:57 pm

Impact: fix 2 make headers_check warnings:

 usr/include/linux/in6.h:47: extern's make no sense in userspace
 usr/include/linux/in6.h:49: extern's make no sense in userspace

Signed-off-by: Jaswinder Singh Rajput &lt;jaswinderrajput@gmail.com&gt;
---
 include/linux/in6.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/in6.h b/include/linux/in6.h
index bc49204..718bf21 100644
--- a/include/linux/in6.h
+++ b/include/linux/in6.h
@@ -44,11 +44,11 @@ struct in6_addr
  * NOTE: Be aware the IN6ADDR_* constants and in6addr_* externals are defined
  * in network byte order, not in host byte order as are the IPv4 equivalents
  */
+#ifdef __KERNEL__
 extern const struct in6_addr in6addr_any;
 #define IN6ADDR_ANY_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 } } }
 extern const struct in6_addr in6addr_loopback;
 #define IN6ADDR_LOOPBACK_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } }
-#ifdef __KERNEL__
 extern const struct in6_addr in6addr_linklocal_allnodes;
 #define IN6ADDR_LINKLOCAL_ALLNODES_INIT	\
 		{ { { 0xff,2,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } }
-- 
1.5.6.6



--

[ message continues ]

[view original message]

From: Sam Ravnborg

Subject: Re: [PATCH -tip] in6.h: extern's make no sense in userspace

Date: Tuesday, January 13, 2009 - 12:15 am

It looks wrong what IN6ADDR_ANY_INIT should be a kernel only symbol.
At least google had some hits on that symbol.

netdev people should know....

	Sam
--

[ message continues ]

[view original message]

From: Jaswinder Singh Rajput

Subject: Re: [PATCH -tip] in6.h: extern's make no sense in userspace

Date: Tuesday, January 13, 2009 - 12:20 am

OK, I do not want any conflicts and I want to stay in safe side ;-)

Subject: [PATCH] in6.h: extern's make no sense in userspace

Impact: fix 2 make headers_check warnings:

 usr/include/linux/in6.h:47: extern's make no sense in userspace
 usr/include/linux/in6.h:49: extern's make no sense in userspace

Signed-off-by: Jaswinder Singh Rajput &lt;jaswinderrajput@gmail.com&gt;
---
 include/linux/in6.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/in6.h b/include/linux/in6.h
index bc49204..44d921c 100644
--- a/include/linux/in6.h
+++ b/include/linux/in6.h
@@ -44,11 +44,11 @@ struct in6_addr
  * NOTE: Be aware the IN6ADDR_* constants and in6addr_* externals are defined
  * in network byte order, not in host byte order as are the IPv4 equivalents
  */
-extern const struct in6_addr in6addr_any;
 #define IN6ADDR_ANY_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 } } }
-extern const struct in6_addr in6addr_loopback;
 #define IN6ADDR_LOOPBACK_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } }
 #ifdef __KERNEL__
+extern const struct in6_addr in6addr_any;
+extern const struct in6_addr in6addr_loopback;
 extern const struct in6_addr in6addr_linklocal_allnodes;
 #define IN6ADDR_LINKLOCAL_ALLNODES_INIT	\
 		{ { { 0xff,2,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } }
-- 
1.5.6.6



--

[ message continues ]

[view original message]

From: David Miller

Subject: Re: [PATCH -tip] in6.h: extern's make no sense in userspace

Date: Tuesday, January 13, 2009 - 12:22 am

From: Sam Ravnborg &lt;sam@ravnborg.org&gt;

It is defined by libc's /usr/include/netinet/in.h
--

[ message continues ]