[PATCH 03/16] dma-debug: add hash functions for dma_debug_entries

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Joerg Roedel
Date: Friday, January 9, 2009 - 9:19 am

Impact: implement necessary functions for the core hash

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 lib/dma-debug.c |  101 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 101 insertions(+), 0 deletions(-)

diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index d04f8b6..74a0f36 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -18,9 +18,14 @@
  */
 
 #include <linux/dma-debug.h>
+#include <linux/spinlock.h>
 #include <linux/types.h>
 #include <linux/list.h>
 
+#define HASH_SIZE       256
+#define HASH_FN_SHIFT   20
+#define HASH_FN_MASK    0xffULL
+
 enum {
 	dma_debug_single,
 	dma_debug_sg,
@@ -37,3 +42,99 @@ struct dma_debug_entry {
 	int              direction;
 };
 
+struct hash_bucket {
+	struct list_head list;
+	spinlock_t lock;
+} ____cacheline_aligned;
+
+/* Hash list to save the allocated dma addresses */
+static struct hash_bucket dma_entry_hash[HASH_SIZE];
+
+/*
+ * Hash related functions
+ *
+ * Every DMA-API request is saved into a struct dma_debug_entry. To
+ * have quick access to these structs they are stored into a hash.
+ */
+static int hash_fn(struct dma_debug_entry *entry)
+{
+	/*
+	 * Hash function is based on the dma address.
+	 * We use bits 20-27 here as the index into the hash
+	 */
+	return (entry->dev_addr >> HASH_FN_SHIFT) & HASH_FN_MASK;
+}
+
+/*
+ * Request exclusive access to a hash bucket for a given dma_debug_entry.
+ */
+static struct hash_bucket *get_hash_bucket(struct dma_debug_entry *entry,
+					   unsigned long *flags)
+{
+	int idx = hash_fn(entry);
+	unsigned long __flags;
+
+	spin_lock_irqsave(&dma_entry_hash[idx].lock, __flags);
+	*flags = __flags;
+	return &dma_entry_hash[idx];
+}
+
+/*
+ * Give up exclusive access to the hash bucket
+ */
+static void put_hash_bucket(struct hash_bucket *bucket,
+			    unsigned long *flags)
+{
+	unsigned long __flags = *flags;
+
+	spin_unlock_irqrestore(&bucket->lock, __flags);
+}
+
+/*
+ * Search a given entry in the hash bucket list
+ */
+static struct dma_debug_entry *hash_bucket_find(struct hash_bucket *bucket,
+						struct dma_debug_entry *ref)
+{
+	struct dma_debug_entry *entry;
+
+	list_for_each_entry(entry, &bucket->list, list) {
+		if ((entry->dev_addr == ref->dev_addr) &&
+		    (entry->dev == ref->dev))
+			return entry;
+	}
+
+	return NULL;
+}
+
+/*
+ * Add an entry to a hash bucket
+ */
+static void hash_bucket_add(struct hash_bucket *bucket,
+			    struct dma_debug_entry *entry)
+{
+	list_add_tail(&entry->list, &bucket->list);
+}
+
+/*
+ * Remove entry from a hash bucket list
+ */
+static void hash_bucket_del(struct dma_debug_entry *entry)
+{
+	list_del(&entry->list);
+}
+
+/*
+ * Wrapper function for adding an entry to the hash.
+ * This function takes care of locking itself.
+ */
+static void add_dma_entry(struct dma_debug_entry *entry)
+{
+	struct hash_bucket *bucket;
+	unsigned long flags;
+
+	bucket = get_hash_bucket(entry, &flags);
+	hash_bucket_add(bucket, entry);
+	put_hash_bucket(bucket, &flags);
+}
+
-- 
1.5.6.4


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/16] DMA-API debugging facility v2, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 01/16] dma-debug: add Kconfig entry, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 03/16] dma-debug: add hash functions for dma_debug_ ..., Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 04/16] dma-debug: add allocator code, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 05/16] dma-debug: add initialization code, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 07/16] dma-debug: add debugfs interface, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 08/16] dma-debug: add core checking functions, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 12/16] dma-debug: add checks for sync_single_*, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 15/16] dma-debug: x86 architecture bindings, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 16/16] dma-debug: Documentation update, Joerg Roedel, (Fri Jan 9, 9:19 am)
Re: [PATCH 05/16] dma-debug: add initialization code, Evgeniy Polyakov, (Fri Jan 9, 10:58 am)
Re: [PATCH 05/16] dma-debug: add initialization code, Joerg Roedel, (Fri Jan 9, 11:17 am)
Re: [PATCH 01/16] dma-debug: add Kconfig entry, Randy Dunlap, (Fri Jan 9, 1:12 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, Michael Chan, (Fri Jan 9, 2:24 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, Joerg Roedel, (Fri Jan 9, 3:33 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, Joerg Roedel, (Fri Jan 9, 3:37 pm)
Re: [PATCH 15/16] dma-debug: x86 architecture bindings, Ingo Molnar, (Sat Jan 10, 4:04 pm)
Re: [PATCH 07/16] dma-debug: add debugfs interface, Ingo Molnar, (Sat Jan 10, 4:08 pm)
Re: [PATCH 07/16] dma-debug: add debugfs interface, Ingo Molnar, (Sat Jan 10, 4:15 pm)
Re: [PATCH 04/16] dma-debug: add allocator code, Ingo Molnar, (Sat Jan 10, 4:43 pm)
Re: [PATCH 15/16] dma-debug: x86 architecture bindings, Ingo Molnar, (Sat Jan 10, 4:48 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, Ingo Molnar, (Sat Jan 10, 4:54 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, FUJITA Tomonori, (Sat Jan 10, 11:25 pm)
Re: [PATCH 15/16] dma-debug: x86 architecture bindings, FUJITA Tomonori, (Sat Jan 10, 11:25 pm)
Re: [PATCH 07/16] dma-debug: add debugfs interface, Joerg Roedel, (Sun Jan 11, 12:52 am)
Re: [PATCH 08/16] dma-debug: add core checking functions, Joerg Roedel, (Sun Jan 11, 12:54 am)
Re: [PATCH 08/16] dma-debug: add core checking functions, Joerg Roedel, (Sun Jan 11, 12:57 am)
Re: [PATCH 15/16] dma-debug: x86 architecture bindings, Joerg Roedel, (Sun Jan 11, 1:08 am)
Re: [PATCH 0/16] DMA-API debugging facility v2, Joerg Roedel, (Sun Jan 11, 1:11 am)
Re: [PATCH 07/16] dma-debug: add debugfs interface, Joerg Roedel, (Wed Jan 14, 8:22 am)
Re: [PATCH 0/16] DMA-API debugging facility v2, David Woodhouse, (Thu Feb 5, 3:52 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, Chris Wright, (Thu Feb 5, 7:05 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, Chris Wright, (Thu Feb 5, 7:27 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, David Woodhouse, (Fri Feb 6, 12:56 am)
Re: [PATCH 0/16] DMA-API debugging facility v2, Chris Wright, (Fri Feb 6, 9:08 am)
Re: [PATCH 0/16] DMA-API debugging facility v2, Chris Wright, (Fri Feb 6, 11:20 am)
Re: [PATCH 0/16] DMA-API debugging facility v2, Joerg Roedel, (Thu Feb 12, 7:48 am)
Re: [PATCH 0/16] DMA-API debugging facility v2, Joerg Roedel, (Thu Feb 12, 8:20 am)