[PATCH] ucc_geth: Convert to net_device_ops

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <leoli@...>, <netdev@...>, <linuxppc-dev@...>, Anton Vorontsov <avorontsov@...>
Date: Monday, March 23, 2009 - 6:17 am

Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
---

Sorry for the WS damaged patch, but my current company mailer cannot
handle inline patches. Due to this we are setting up a new mail system
but it will be a few days before this is ready.
Therefore I am attaching this patch as well, use that one
to apply instaed of the inline variant.


 drivers/net/ucc_geth.c |   28 +++++++++++++++++++---------
 1 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index 12e5c3d..d3f6eee 100644
--- a/drivers/net/ucc_geth.c
+++ b/drivers/net/ucc_geth.c
@@ -3503,6 +3503,24 @@ static phy_interface_t to_phy_interface(const char 
*phy_connection_type)
        return PHY_INTERFACE_MODE_MII;
 }
 
+static const struct net_device_ops ucc_geth_netdev_ops = {
+       .ndo_open               = ucc_geth_open,
+       .ndo_stop               = ucc_geth_close,
+       .ndo_start_xmit         = ucc_geth_start_xmit,
+       .ndo_validate_addr      = eth_validate_addr,
+       .ndo_set_multicast_list = ucc_geth_set_multi,
+#if 0
+/* not yet */
+       .ndo_set_mac_address    = ucc_geth_set_mac_address,
+       .ndo_change_mtu         = ucc_geth_change_mtu,
+       .ndo_do_ioctl           = ucc_geth_do_ioctl,
+#endif
+       .ndo_tx_timeout         = ucc_geth_timeout,
+#ifdef CONFIG_NET_POLL_CONTROLLER
+       .ndo_poll_controller    = ucc_netpoll,
+#endif
+};
+
 static int ucc_geth_probe(struct of_device* ofdev, const struct 
of_device_id *match)
 {
        struct device *device = &ofdev->dev;
@@ -3715,19 +3733,11 @@ static int ucc_geth_probe(struct of_device* ofdev, 
const struct of_device_id *ma
 
        /* Fill in the dev structure */
        uec_set_ethtool_ops(dev);
-       dev->open = ucc_geth_open;
-       dev->hard_start_xmit = ucc_geth_start_xmit;
-       dev->tx_timeout = ucc_geth_timeout;
+       dev->netdev_ops = &ucc_geth_netdev_ops;
        dev->watchdog_timeo = TX_TIMEOUT;
        INIT_WORK(&ugeth->timeout_work, ucc_geth_timeout_work);
        netif_napi_add(dev, &ugeth->napi, ucc_geth_poll, 
UCC_GETH_DEV_WEIGHT);
-#ifdef CONFIG_NET_POLL_CONTROLLER
-       dev->poll_controller = ucc_netpoll;
-#endif
-       dev->stop = ucc_geth_close;
-//    dev->change_mtu = ucc_geth_change_mtu;
        dev->mtu = 1500;
-       dev->set_multicast_list = ucc_geth_set_multi;
 
        ugeth->msg_enable = netif_msg_init(debug.msg_enable, 
UGETH_MSG_DEFAULT);
        ugeth->phy_interface = phy_interface;
-- 
1.6.1.3
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ucc_geth: Convert to net_device_ops, Joakim Tjernlund, (Mon Mar 23, 6:17 am)
Re: [PATCH] ucc_geth: Convert to net_device_ops, David Miller, (Mon Mar 23, 2:49 pm)
Re: [PATCH] ucc_geth: Convert to net_device_ops, Joakim Tjernlund, (Tue Mar 24, 6:37 am)
Re: [PATCH] ucc_geth: Convert to net_device_ops, David Miller, (Tue Mar 24, 5:22 pm)
Re: [PATCH] ucc_geth: Convert to net_device_ops, Joakim Tjernlund, (Tue Mar 24, 6:45 pm)
Re: [PATCH] ucc_geth: Convert to net_device_ops, David Miller, (Tue Mar 24, 6:49 pm)
Re: [PATCH] ucc_geth: Convert to net_device_ops, Joakim Tjernlund, (Tue Mar 24, 7:08 pm)
Re: [PATCH] ucc_geth: Convert to net_device_ops, Timur Tabi, (Fri Mar 27, 2:50 pm)
Re: [PATCH] ucc_geth: Convert to net_device_ops, Joakim Tjernlund, (Sat Mar 28, 7:27 am)
Re: [PATCH] ucc_geth: Convert to net_device_ops, David Miller, (Tue Mar 24, 7:29 pm)
Re: [PATCH] ucc_geth: Convert to net_device_ops, Joakim Tjernlund, (Tue Mar 24, 7:35 pm)