Re: INET_LRO as tristate and use from modules

Previous thread: [RFC PATCH v3 00/17] virtual-bus by Gregory Haskins on Tuesday, April 21, 2009 - 11:34 am. (20 messages)

Next thread: [PATCH] snmp: add missing counters for RFC 4293 by Neil Horman on Tuesday, April 21, 2009 - 12:39 pm. (26 messages)
From: Subrata Modak
Date: Tuesday, April 21, 2009 - 11:53 am

Reported this on 9th April earlier:
http://lkml.org/lkml/2009/4/9/276,

I hope the following Patch will solve this problem as well:
Geoff Levand <geoffrey.levand@am.sony.com> provided a patch on 17th
April.
http://lkml.org/lkml/2009/4/17/313,

WRAP    arch/powerpc/boot/zImage.pmac
strip -s -R .comment vmlinux -o arch/powerpc/boot/zImage.iseries
printf "\x02" | dd of=arch/powerpc/boot/zImage.iseries conv=notrunc bs=1
seek=17
1+0 records in
1+0 records out
1 byte (1 B) copied, 0.0358298 s, 0.0 kB/s
  Building modules, stage 2.
  MODPOST 338 modules
ERROR: ".lro_receive_skb" [drivers/net/pasemi_mac_driver.ko] undefined!
ERROR: ".lro_flush_all" [drivers/net/pasemi_mac_driver.ko] undefined!
WARNING: modpost: Found 1 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
---

Regards--
Subrata


This seems to be a problem with all tristate-capable drivers that use
LRO (and uses select INET_LRO in their Kconfig): INET_LRO is a tristate
and can thus be a module. Looks like it needs to be a bool instead?


-Olof

--

From: David Miller
Date: Wednesday, April 22, 2009 - 2:12 am

From: Olof Johansson <olof@lixom.net>

Yes, making this a bool would be the easiest fix.

By why don't we get the same problem for PHYLIB?  It's also
tristate and "select"'d by a whole slew of networking drivers.
--

From: David Miller
Date: Friday, May 8, 2009 - 12:43 pm

From: David Miller <davem@davemloft.net>

I guess nobody has any idea...

I'll just make INET_LRO a bool to fix this.
--

Previous thread: [RFC PATCH v3 00/17] virtual-bus by Gregory Haskins on Tuesday, April 21, 2009 - 11:34 am. (20 messages)

Next thread: [PATCH] snmp: add missing counters for RFC 4293 by Neil Horman on Tuesday, April 21, 2009 - 12:39 pm. (26 messages)