Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jarek Poplawski
Date: Tuesday, January 19, 2010 - 3:47 am

On Tue, Jan 19, 2010 at 12:46:24AM -0500, Michael Breuer wrote:
...

Btw, could you try if this patch can makes difference in triggering
the "lib/dma-debug.c:898" warning?

Jarek P.
---

 drivers/net/sky2.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 7650f73..e02e9e9 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -2479,6 +2479,9 @@ static int sky2_status_intr(struct sky2_hw *hw, int to_do, u16 idx)
 
 		port = le->css & CSS_LINK_BIT;
 		dev = hw->dev[port];
+		if (!netif_running(dev))
+			continue;
+
 		sky2 = netdev_priv(dev);
 		length = le16_to_cpu(le->length);
 		status = le32_to_cpu(le->status);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Tue Jan 5, 4:07 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Wed Jan 6, 12:22 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Stephen Hemminger, (Wed Jan 6, 2:10 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Stephen Hemminger, (Wed Jan 6, 9:53 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 12:47 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 10:56 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 11:01 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 11:17 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 11:35 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 11:50 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 12:36 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Fri Jan 8, 12:45 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Wed Jan 13, 2:09 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Wed Jan 13, 2:34 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Sun Jan 17, 3:17 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Sun Jan 17, 4:05 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 12:30 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 1:46 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Stephen Hemminger, (Mon Jan 18, 2:00 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 2:06 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 2:25 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 2:50 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 3:08 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 3:17 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 3:40 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Michael Breuer, (Mon Jan 18, 10:46 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Tue Jan 19, 1:41 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Tue Jan 19, 3:47 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Tue Jan 19, 12:59 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Tue Jan 19, 1:29 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Tue Jan 19, 3:45 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Stephen Hemminger, (Tue Jan 19, 6:10 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Michael Breuer, (Thu Jan 21, 12:48 pm)