Re: __bad_udelay in network driver breaks build

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Monday, October 25, 2010 - 1:05 pm

From: Andi Kleen <andi@firstfloor.org>
Date: Mon, 18 Oct 2010 13:52:30 +0200


Let me know if this fixes things:

--------------------
tms380tr: Use mdelay() in tms380tr_wait().

This driver tries to do up to half-second udelay()
calls, which overflows on x86-64.

Reported-by: Andi Kleen <andi@firstfloor.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/tokenring/tms380tr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/tokenring/tms380tr.c b/drivers/net/tokenring/tms380tr.c
index 663b886..7930203 100644
--- a/drivers/net/tokenring/tms380tr.c
+++ b/drivers/net/tokenring/tms380tr.c
@@ -1220,7 +1220,7 @@ void tms380tr_wait(unsigned long time)
 		tmp = schedule_timeout_interruptible(tmp);
 	} while(time_after(tmp, jiffies));
 #else
-	udelay(time);
+	mdelay(time / 1000);
 #endif
 }
 
-- 
1.7.3.2

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
__bad_udelay in network driver breaks build, Andi Kleen, (Mon Oct 18, 4:52 am)
Re: __bad_udelay in network driver breaks build, David Miller, (Mon Oct 25, 1:05 pm)
Re: __bad_udelay in network driver breaks build, Andi Kleen, (Mon Oct 25, 3:10 pm)
Re: __bad_udelay in network driver breaks build, David Miller, (Mon Oct 25, 4:48 pm)
RE: __bad_udelay in network driver breaks build, Duyck, Alexander H, (Tue Oct 26, 10:34 am)
RE: __bad_udelay in network driver breaks build, Rose, Gregory V, (Tue Oct 26, 10:36 am)