Re: ixgbe: normalize frag_list usage

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Wednesday, October 6, 2010 - 11:58 pm

From: "Duyck, Alexander H" <alexander.h.duyck@intel.com>
Date: Tue, 5 Oct 2010 15:45:32 -0700


Can you really not remember the head somewhere?

What I wanted is for everyone to build their frag list SKBs from head to tail,
always.  So that I could, as I mentioned in my original posting, do something
like:

struct sk_buff {
	union {
		struct list_head list;
		struct {
			struct sk_buff	*frag_next;
			struct sk_buff	*frag_tail_tracker;
		};
	};
};

The ->frag_tail_tracker is only used in the head SKB to maintain where the
last SKB in the frag list is.

You're tracking the head from the inner SKBs, such that my intended
conventions are not being followed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
ixgbe: normalize frag_list usage, David Miller, (Sun Oct 3, 11:54 pm)
RE: ixgbe: normalize frag_list usage, Rose, Gregory V, (Mon Oct 4, 8:37 am)
Re: ixgbe: normalize frag_list usage, Alexander Duyck, (Mon Oct 4, 11:04 am)
Re: ixgbe: normalize frag_list usage, David Miller, (Mon Oct 4, 11:32 am)
Re: ixgbe: normalize frag_list usage, Alexander Duyck, (Mon Oct 4, 12:49 pm)
RE: ixgbe: normalize frag_list usage, Duyck, Alexander H, (Tue Oct 5, 3:45 pm)
Re: ixgbe: normalize frag_list usage, David Miller, (Tue Oct 5, 8:08 pm)
Re: ixgbe: normalize frag_list usage, David Miller, (Wed Oct 6, 11:58 pm)
Re: ixgbe: normalize frag_list usage, Alexander Duyck, (Thu Oct 7, 12:59 pm)
[RFC] ixgbe: v3 normalize frag_list usage, Duyck, Alexander H, (Fri Oct 8, 4:57 pm)
Re: ixgbe: normalize frag_list usage, David Miller, (Wed Oct 13, 7:17 pm)
Re: [RFC] ixgbe: v3 normalize frag_list usage, David Miller, (Mon Oct 25, 12:47 pm)