| Ben Hutchings | Re: pull request: sfc-2.6 2010-12-07
That should of course be:
git://git.kernel.org/pub/scm/linux/kernel/git/bwh/sfc-2.6.git sfc-2.6.37
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
| Dec 7, 2:45 pm 2010 |
| Ben Hutchings | pull request: sfc-2.6 2010-12-07
The following changes since commit 46bcf14f44d8f31ecfdc8b6708ec15a3b33316d9:
filter: fix sk_filter rcu handling (2010-12-06 09:29:43 -0800)
are available in the git repository at:
git://git.kernel.org/linux/kernel/git/bwh/sfc-2.6.git sfc-2.6.37
(or will be shortly).
These fix bugs introduced in 2.6.37-rc1. Please pull.
Ben.
Ben Hutchings (2):
sfc: Fix crash in legacy onterrupt handler during ring reallocation
sfc: Fix NAPI list corruption during ring reallocation
...
| Dec 7, 2:40 pm 2010 |
| Ben Hutchings | [PATCH net-2.6 1/2] sfc: Fix crash in legacy onterrupt h ...
If we are using a legacy interrupt, our IRQ may be shared and our
interrupt handler may be called even though interrupts are disabled on
the NIC. When we change ring sizes, we reallocate the event queue and
the interrupt handler may use an invalid pointer when called for
another device's interrupt.
Maintain a legacy_irq_enabled flag and test that at the top of the
interrupt handler. Note that this problem results from the need to
work around broken INT_ISR0 reads, and does not affect the ...
| Dec 7, 2:42 pm 2010 |
| Ben Hutchings | [PATCH net-2.6 2/2] sfc: Fix NAPI list corruption during ...
Call netif_napi_{add,del}() on the NAPI contexts in the new and
old channels, respectively.
Since efx_init_napi() cannot fail, make its return type void.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
drivers/net/sfc/efx.c | 31 +++++++++++++++++++------------
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/net/sfc/efx.c b/drivers/net/sfc/efx.c
index d06cb74..fb83cdd 100644
--- a/drivers/net/sfc/efx.c
+++ b/drivers/net/sfc/efx.c
@@ -197,7 +197,9 ...
| Dec 7, 2:42 pm 2010 |
| Eric Dumazet | [PATCH] tcp: avoid a possible divide by zero
Thanks
Great, I feel we are going to fix all sysctls, one by one then :(
lkml removed from Cc
[PATCH] tcp: avoid a possible divide by zero
sysctl_tcp_tso_win_divisor might be set to zero while one cpu runs in
tcp_tso_should_defer(). Make sure we dont allow a divide by zero by
reading sysctl_tcp_tso_win_divisor once.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
net/ipv4/tcp_output.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git ...
| Dec 7, 2:28 pm 2010 |
| Eric Dumazet | [PATCH] tcp: protect sysctl_tcp_cookie_size reads
Make sure sysctl_tcp_cookie_size is read once in
tcp_cookie_size_check(), or we might return an illegal value to caller
if sysctl_tcp_cookie_size is changed by another cpu.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Cc: William Allen Simpson <william.allen.simpson@gmail.com>
---
net/ipv4/tcp_output.c | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/net/ipv4/tcp_output.c ...
| Dec 7, 3:20 pm 2010 |
| Eric Dumazet | Re: [PATCH] tcp: avoid a possible divide by zero
Yes, I knew that, of course :)
I wonder how many bugs like that we have in sysctls
Thanks
[PATCH v2] tcp: avoid a possible divide by zero
sysctl_tcp_tso_win_divisor might be set to zero while one cpu runs in
tcp_tso_should_defer(). Make sure we dont allow a divide by zero by
reading sysctl_tcp_tso_win_divisor exactly once.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
v2: Use ACCESS_ONCE() as Ben suggested
net/ipv4/tcp_output.c | 6 ++++--
1 file changed, 4 ...
| Dec 7, 3:03 pm 2010 |
| Ben Hutchings | Re: [PATCH] tcp: avoid a possible divide by zero
On Tue, 2010-12-07 at 22:28 +0100, Eric Dumazet wrote:
You need to use ACCESS_ONCE(sysctl_tcp_tso_win_divisor). Otherwise the
compiler may eliminate the local variable and read the global twice.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
| Dec 7, 2:32 pm 2010 |
| Apollon Oikonomopoulos | [PATCH] X.25: decrement netdev reference counts on unload
Hello,
We came across this bug when we accidentally loaded and unloaded the x25
kernel module on a host with KVM virtual machines. All subsequent
attempts to stop a KVM instance resulted in the KVM process entering D
state. Reproducing this behaviour can be done in the following way:
1. modprobe x25
2. tunctl && ifconfig tap0 up
3. rmmod x25
4. tunctl -d tap0 (hangs)
A patch follows - we don't use X.25 ourselves so I'm not sure it won't
panic someone's ...
| Dec 7, 12:43 pm 2010 |
| Andrew Hendry |
| Dec 7, 3:48 pm 2010 |
| PRIVATE HOME LENDER INC |
| Dec 7, 11:52 am 2010 |
| Alan Stern | Re: Fwd: usbnet: Recursive Locking bug ?
A simple answer to Oliver's question is to take a reference to the
URB while still holding the lock, then release the lock before calling
usb_unlink_urb(), then drop the reference to the URB.
Of course, this also requires you to restart the loop from the
beginning after each unlink, and it means you need to have a way to
recognize when an URB has already been unlinked.
Alan Stern
--
| Dec 7, 9:46 am 2010 |
| Ilya Loginov | WARNING at local_bh_enable while tcp_retransmit
Hi, I am working on some network drivers.
First one is raw netdevice for RapidIO packets. Second one is
Ethernet network device that encapsulates Ethernet traffic into RapidIO
messages.
Ethernet device changes skb->dev to RapidIO device, calls
RapidIO create_header and calls dev_queue_xmit on skb.
All works well for linear skb's but I have trouble with
multi-fragment skb's when frags have bad alignment. In that case my
controller RapidIO fails to transmit packets. While a bit internal ...
| Dec 7, 8:23 am 2010 |
| Jarek Poplawski |
| Dec 7, 1:56 pm 2010 |
| Changli Gao | [PATCH] af_packet: fix freeing pg_vec twice on error path
It is introduced in:
commit 0e3125c755445664f00ad036e4fc2cd32fd52877
Author: Neil Horman <nhorman@tuxdriver.com>
Date: Tue Nov 16 10:26:47 2010 -0800
packet: Enhance AF_PACKET implementation to not require high order contiguous memory allocation (v4)
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
---
net/packet/af_packet.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 0e152b1..d163f78 ...
| Dec 7, 8:05 am 2010 |
| Changli Gao | [PATCH] af_packet: eliminate pgv_to_page on some arches
Some arches don't need flush_dcache_page(), and don't implement it, so
we can eliminate pgv_to_page() calls on those arches.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
---
net/packet/af_packet.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index a11c731..0e152b1 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -223,7 +223,7 @@ struct packet_skb_cb {
#define PACKET_SKB_CB(__skb) ((struct ...
| Dec 7, 7:26 am 2010 |
| Oliver Neukum | Re: usbnet: Recursive Locking bug ?
But what makes sure that the URB unlinked in unlink_urbs() stays a valid pointer?
The bottom half may run and free the URB.
Regards
Oliver
--
| Dec 7, 7:54 am 2010 |
| Neil Jones | usbnet: Recursive Locking bug ?
Hi,
I get a recursice lock warning from usbnet (asix adapter) with lockdep
checking on:
=============================================
[ INFO: possible recursive locking detected ]
2.6.37-rc4+ #1695
---------------------------------------------
ifconfig/536 is trying to acquire lock:
(&(&list->lock)->rlock#2){-.-...}, at: [<401a63bc>] _defer_bh+0x24/0x124
but task is already holding lock:
(&(&list->lock)->rlock#2){-.-...}, at: [<401a5f28>] _unlink_urbs+0x1c/0xa8
other info that might ...
| Dec 7, 7:08 am 2010 |
| Neil Jones | Fwd: usbnet: Recursive Locking bug ?
I think it may be safe to remove the lock as we are walking a list of
SKBs not URBs,
the BH can remove SKB's from the list but we are doing a safe list walk.
+ the BH takse the list lock when it does the remove.
I could be wrong though?
--
| Dec 7, 9:15 am 2010 |
| Google End Of Year Promo |
| Dec 7, 4:28 am 2010 |
| Jarek Poplawski |
| Dec 7, 3:09 pm 2010 |
| Jarek Poplawski |
| Dec 7, 3:01 pm 2010 |
| Dan Carpenter | [patch] econet: unlock on -EPERM path
We need to do a mutex_unlock() and a put_dev() before returning.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c
index 13992e1..f180371 100644
--- a/net/econet/af_econet.c
+++ b/net/econet/af_econet.c
@@ -661,8 +661,10 @@ static int ec_dev_ioctl(struct socket *sock, unsigned int cmd, void __user *arg)
err = 0;
switch (cmd) {
case SIOCSIFADDR:
- if (!capable(CAP_NET_ADMIN))
- return -EPERM;
+ if ...
| Dec 7, 4:01 am 2010 |
| Martin Willi | [PATCH 0/3] xfrm: ESP Traffic Flow Confidentiality paddi ...
The following patchset adds Traffic Flow Confidentiality padding. The
first patch introduces a new Netlink XFRM attribute to configure TFC via
userspace. Patch two and three implement the padding logic in IPv4 and
IPv6 ESP. Padding is always done using the RFC4303 format an is clamped
to the PMTU.
Changes from v1:
- Always clamp padding length to never exceed PMTU
- Remove XFRM_TFC_PMTU flag, use USHRT_MAX padding length instead
- Remove ESPv2 padding fallback due to the concerns from ...
| Dec 7, 3:29 am 2010 |
| Martin Willi | [PATCH 2/3] xfrm: Traffic Flow Confidentiality for IPv4 ESP
Add TFC padding to all packets smaller than the boundary configured
on the xfrm state. If the boundary is larger than the PMTU, limit
padding to the PMTU.
Signed-off-by: Martin Willi <martin@strongswan.org>
---
net/ipv4/esp4.c | 33 +++++++++++++++++++++++++--------
1 files changed, 25 insertions(+), 8 deletions(-)
diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c
index 14ca1f1..e7784e8 100644
--- a/net/ipv4/esp4.c
+++ b/net/ipv4/esp4.c
@@ -23,6 +23,8 @@ struct esp_skb_cb {
#define ...
| Dec 7, 3:29 am 2010 |
| Martin Willi | [PATCH 1/3] xfrm: Add Traffic Flow Confidentiality paddi ...
The XFRMA_TFC attribute for XFRM state installation configures
Traffic Flow Confidentiality by padding ESP packets to a specified
length.
Signed-off-by: Martin Willi <martin@strongswan.org>
---
include/linux/xfrm.h | 6 ++++++
include/net/xfrm.h | 1 +
net/xfrm/xfrm_user.c | 16 ++++++++++++++--
3 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h
index b971e38..7cd5232 100644
--- a/include/linux/xfrm.h
+++ ...
| Dec 7, 3:29 am 2010 |
| Martin Willi | [PATCH 3/3] xfrm: Traffic Flow Confidentiality for IPv6 ESP
Add TFC padding to all packets smaller than the boundary configured
on the xfrm state. If the boundary is larger than the PMTU, limit
padding to the PMTU.
Signed-off-by: Martin Willi <martin@strongswan.org>
---
net/ipv6/esp6.c | 33 +++++++++++++++++++++++++--------
1 files changed, 25 insertions(+), 8 deletions(-)
diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c
index ee9b93b..8b493b0 100644
--- a/net/ipv6/esp6.c
+++ b/net/ipv6/esp6.c
@@ -49,6 +49,8 @@ struct esp_skb_cb {
#define ...
| Dec 7, 3:29 am 2010 |
| Steffen Klassert | [PATCH] xfrm: Fix xfrm_state_migrate leak
From: Thomas Egerer <thomas.egerer@secunet.com>
xfrm_state_migrate calls kfree instead of xfrm_state_put to free
a failed state. According to git commit 553f9118 this can cause
memory leaks.
Signed-off-by: Thomas Egerer <thomas.egerer@secunet.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
net/xfrm/xfrm_state.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index eb96ce5..220ebc0 100644
--- ...
| Dec 7, 2:28 am 2010 |
| Herbert Xu |
| Dec 7, 2:31 am 2010 |
| Marc Kleine-Budde | Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change ...
According to my man page it's:
--cc=<address>
Try the above parameter format, if it doesn't work talk to your IT guys.
Have the time stamp and involved addresses (to,cc,smtp-server) of a
working and not working git send-email attempt ready.
cheers, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 ...
| Dec 7, 1:02 am 2010 |
| Tomoya MORINAGA |
| Dec 7, 1:32 am 2010 |
| Eric Dumazet | Re: [PATCH net-next-2.6] net: call dev_queue_xmit_nit() ...
Hmm, this was wrong, and not what I wanted to do :
in dev_queue_xmit_nit() do following tests :
/* Never send packets back to the socket
* they originated from - MvS ( miquels@drinkel.ow.org)
*/
if ((ptype->dev == dev || !ptype->dev) &&
(ptype->af_packet_priv == NULL ||
(struct sock *)ptype->af_packet_priv != skb->sk)) {
struct sk_buff *skb2 = skb_clone(skb, GFP_ATOMIC);
So we should not move dev_queue_xmit_nit() ...
| Dec 7, 3:30 am 2010 |
| Eric Dumazet | [PATCH net-next-2.6] net: call dev_queue_xmit_nit() afte ...
Avoid some atomic ops on dst refcount, calling dev_queue_xmit_nit()
after skb_dst_drop() in dev_hard_start_xmit().
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
Next patch will perform the sk_run_filter() in dev_queue_xmit_nit(),
before cloning skb and af_packet rcv() call.
net/core/dev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 55ff66f..59360ef 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ ...
| Dec 7, 12:19 am 2010 |
| Eric Dumazet | [PATCH net-next-2.6] filter: constify sk_run_filter()
sk_run_filter() doesnt write on skb, change its prototype to reflect
this.
Fix two af_packet comments.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
include/linux/filter.h | 2 +-
net/core/filter.c | 7 ++++---
net/core/timestamping.c | 2 +-
net/packet/af_packet.c | 31 ++++++++++++++++---------------
4 files changed, 22 insertions(+), 20 deletions(-)
diff --git a/include/linux/filter.h b/include/linux/filter.h
index 5334ada..45266b7 100644
--- ...
| Dec 6, 11:50 pm 2010 |
| Jan Beulich |
| Dec 7, 7:38 am 2010 |
| Ben Hutchings | Re: biosdevname v0.3.2
As I understand it, dev_id is supposed to distinguish net devices
corresponding to multiple ports on a single network controller.
However, a value of 0 could mean either 'unspecified' or 'first port' so
you would have to verify that multiple net devices for the same slot
have unique dev_id values before taking them into account.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to ...
| Dec 7, 11:41 am 2010 |
| Matt Domsch | Re: biosdevname v0.3.2
Tell me more about the dev_id attribute. I'm happy to use it, but I
don't understand the rules around populating it.
Thanks,
Matt
--
Matt Domsch
Technology Strategist
Dell | Office of the CTO
--
| Dec 7, 11:19 am 2010 |
| Ben Hutchings | Re: biosdevname v0.3.2
[...]
I tried this on a Supermicro board here, which doesn't have this
information. eth0 and eth1 are LOM ports, eth2 and eth3 are on a NIC.
The debug output is:
BIOS device:
Kernel name: eth2
Assigned MAC : 00:0F:53:01:41:14
Driver: sfc
Driver version: 3.0
Firmware version: 3.0.8.2217
Bus Info: 0000:01:00.0
PCI name : 0000:01:00.0
PCI Slot : Unknown
Index in slot: 7
BIOS device:
Kernel name: eth3
Assigned MAC : 00:0F:53:01:41:15
Driver: sfc
Driver version: ...
| Dec 7, 11:16 am 2010 |
| David Brownell | Re: [PATCH] Dot not insert RX urbs if EVENT_DEV_ASLEEP f ...
I realize it's not all your doing, but that's an EVENT not a state flag,
But you're treating it as a state flag. (Like the original somewhat
goofy 69ee472f2706371ca639de49b06df91615c07d8d from Oliver). Even as
a flag, its semantics seem fuzzy... like they should be covered by
other state in the network and/or power management stacks.
I'd like to see this botch fixed, not worsened. Maybe you and Oliver
could collaborate on fixing it, and getting other state flags out ofthe
word used to ...
| Dec 6, 7:49 pm 2010 |
| David Brownell | Re: [PATCH] Insert interrupt URB after resume, so that s ...
Building on my comment about your other patch ... shouldn't this be just
another part of the "resume driver" action,
like refilling the RX urb queue?
For the same reasons ... NAK. It looks like the work to add suspend and
resume processing to this driver had a few holes, and resume handling
can be simplified by combining re-activation of RX processing and this
status reporting (where relevant) in one routine.
- Dave
--
| Dec 6, 7:57 pm 2010 |
| Jarek Poplawski | Re: weird network problem - stalls, reload works
You might try the usual stuff like in linux-2.6/REPORTING-BUGS ;-)
Plus maybe some debugging turned on in the config (DMA?) and
driver (s/#if 0/#if 1/ around line 69 in forcedeth.c). Btw, it
seems there should be some watchdog traces in logs around those
stalled pings.
Cheers,
Jarek P.
--
| Dec 7, 12:20 pm 2010 |
| Kay Sievers | Re: [PATCH] atm: correct sysfs 'device' link creation an ...
Looks good to me.
It's wrong for any subsystem to ever create a file or link named
"device". It's a built-in driver-core managed property which appears
automatically as soon as the parent-device relations are correctly
established.
Udev/libudev intentionally refuses to follow any devices pointed to by
"broken" device links. So this patch is needed to make ATM devices
working properly with usual userspace tools.
Thanks,
Kay
--
| Dec 7, 12:35 am 2010 |
| Greg KH |
| Dec 7, 2:03 pm 2010 |
| Greg KH |
| Dec 7, 12:50 pm 2010 |
| Eric Dumazet |
| Dec 7, 1:50 pm 2010 |
