[PATCH v6 6/7] TCPCT part 2f: cleanup tcp_parse_options

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: William Allen Simpson
Date: Thursday, March 11, 2010 - 5:48 am

Split switch, shift cases to the left, fix most lines beyond column 80.

Add error return.

Harmonize parameter order with other tcp_input functions:
tcp_fast_parse_options() and tcp_validate_incoming().

Harmonize initialization in syncookies.
Fix initialization in tcp_minisocks.

Repair net/ipv4/tcp_ipv4.c errors with goto targets, overlooked by
David Miller in commit bb5b7c11263dbbe78253cd05945a6bf8f55add8e

[updated to latest posted internet draft-simpson-tcpct-00]

Requires:
   TCPCT part 1g: Responder Cookie => Initiator
   net: tcp_header_len_th and tcp_option_len_th

Signed-off-by: William.Allen.Simpson@gmail.com
---
  include/net/tcp.h        |    5 +-
  net/ipv4/syncookies.c    |    9 +-
  net/ipv4/tcp_input.c     |  238 +++++++++++++++++++++++++++-------------------
  net/ipv4/tcp_ipv4.c      |   10 ++-
  net/ipv4/tcp_minisocks.c |   26 ++++--
  net/ipv6/syncookies.c    |    9 +-
  net/ipv6/tcp_ipv6.c      |    6 +-
  7 files changed, 185 insertions(+), 118 deletions(-)
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/7] tcp: bugs and cleanup for 2.6.34-rc1, William Allen Simpson, (Thu Mar 11, 4:35 am)
[PATCH v3 1/7] net: tcp_header_len_th and tcp_option_len_th, William Allen Simpson, (Thu Mar 11, 4:41 am)
[PATCH v4 2/7] net: remove old tcp_optlen function, William Allen Simpson, (Thu Mar 11, 4:53 am)
Re: [PATCH v4 2/7] net: remove old tcp_optlen function, William Allen Simpson, (Thu Mar 11, 4:54 am)
[PATCH v6 3/7] tcp: harmonize tcp_vx_rcv header length ass ..., William Allen Simpson, (Thu Mar 11, 5:08 am)
[PATCH v6 4/7] tcp: input header length, prediction, and t ..., William Allen Simpson, (Thu Mar 11, 5:24 am)
[PATCH v3 5/7] TCPCT part 2e: accept SYNACK data, William Allen Simpson, (Thu Mar 11, 5:31 am)
[PATCH v6 6/7] TCPCT part 2f: cleanup tcp_parse_options, William Allen Simpson, (Thu Mar 11, 5:48 am)
[PATCH v8 7/7] TCPCT part 2g: parse cookie pair and 64-bit ..., William Allen Simpson, (Thu Mar 11, 6:06 am)
Re: [PATCH 0/7] tcp: bugs and cleanup for 2.6.34-rc1, Eric Dumazet, (Thu Mar 11, 8:01 am)
Re: [PATCH 0/7] tcp: bugs and cleanup for 2.6.34-rc1, William Allen Simpson, (Thu Mar 11, 10:38 am)
Re: [PATCH 0/7] tcp: bugs and cleanup for 2.6.34-rc1, Joe Perches, (Thu Mar 11, 11:14 am)
Re: [PATCH v4 2/7] net: remove old tcp_optlen function, Simon Horman, (Thu Mar 11, 5:26 pm)
Re: [PATCH v4 2/7] net: remove old tcp_optlen function, William Allen Simpson, (Fri Mar 12, 6:21 am)
Re: [PATCH v4 2/7] net: remove old tcp_optlen function, William Allen Simpson, (Fri Mar 12, 6:25 am)
Re: [PATCH 0/7] tcp: bugs and cleanup for 2.6.34-rc1, William Allen Simpson, (Fri Mar 12, 6:27 am)
Re: [PATCH v4 2/7] net: remove old tcp_optlen function, Dan Carpenter, (Fri Mar 12, 10:46 am)
Re: [PATCH v4 2/7] net: remove old tcp_optlen function, William Allen Simpson, (Fri Mar 12, 4:05 pm)
Re: [PATCH 0/7] tcp: bugs and cleanup for 2.6.34-rc1, =?utf-8?Q?Am=C3=A9ri ..., (Fri Mar 12, 10:29 pm)
Re: [PATCH v4 2/7] net: remove old tcp_optlen function, Eric Dumazet, (Sat Mar 13, 2:11 am)
Re: [PATCH v4 2/7] net: remove old tcp_optlen function, William Allen Simpson, (Sat Mar 13, 4:12 am)
Re: [PATCH v4 2/7] net: remove old tcp_optlen function, Eric Dumazet, (Sat Mar 13, 4:24 am)