Wed, Mar 03, 2010 at 05:42:56PM CET, jussi.kivilinna@mbnet.fi wrote:
quoted text
>Hello!
>
>Quoting "Jiri Pirko" <jpirko@redhat.com>:
>
>>+	} else if (mc_count) {
>>+		int size = min(priv->multicast_size, mc_count);
>>+		int i = 0;
>>+
>>+		mc_addrs = kmalloc(size * ETH_ALEN, GFP_ATOMIC);
>...
>>+	if (filter != basefilter)
>>+		goto set_filter;
>>+
>>+	if (mc_count) {
>>+		ret = rndis_set_oid(usbdev, OID_802_3_MULTICAST_LIST, mc_addrs,
>>+				    mc_count * ETH_ALEN);
>>+		kfree(mc_addrs);
>
>mc_addrs was alloced by with 'size * ETH_ALEN', which might be less
>than mc_count * ETH_ALEN.

Actually it cannot. That's covered by:

if (mc_count > priv->multicast_size) {

This was also in the original code. In that case "size" can be eliminated and
"mc_addrs" can be allocated with "mc_count * ETH_ALEN".

Jussi are you ok with this?

Jirka
quoted text
>
>Otherwise ok, and rndis_wlan works.
>
> -Jussi
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html