Home » Mailing list archives » linux-netdev » 2010 » July » 3

Re: [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_set_flags to validate flags

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Randy Dunlap
Subject: Re: [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_set_flags to validate flags
Date: Saturday, July 3, 2010 - 12:07 pm

On Fri, 02 Jul 2010 22:07:11 -0700 (PDT) David Miller wrote:


Yep, my bad.

In include/linux/ethtool.h, struct ethtool_ops, field/member 'set_flags':

	int	(*set_flags)(struct net_device *, u32);

Does that need another u32 for 'supported'?  This is where the linux-next
warnings are coming from.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_set_fl ..., Ben Hutchings, (Wed Jun 30, 5:44 am)
[PATCH net-next-2.6 2/3] netdev: Make ethtool_ops::set_fla ..., Ben Hutchings, (Wed Jun 30, 5:46 am)
[PATCH net-next-2.6 3/3] vmxnet3: Remove incorrect impleme ..., Ben Hutchings, (Wed Jun 30, 5:47 am)
Re: [PATCH net-next-2.6 2/3] netdev: Make ethtool_ops::set ..., Eilon Greenstein, (Wed Jun 30, 8:01 am)
RE: [Pv-drivers] [PATCH net-next-2.6 3/3] vmxnet3: Remove ..., Bhavesh Davda, (Wed Jun 30, 8:44 am)
RE: [Pv-drivers] [PATCH net-next-2.6 3/3] vmxnet3: Remove ..., Ben Hutchings, (Wed Jun 30, 8:58 am)
RE: [Pv-drivers] [PATCH net-next-2.6 3/3] vmxnet3: Remove ..., Bhavesh Davda, (Wed Jun 30, 9:46 am)
Re: [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_se ..., David Miller, (Wed Jun 30, 2:10 pm)
Re: [PATCH net-next-2.6 2/3] netdev: Make ethtool_ops::set ..., David Miller, (Wed Jun 30, 2:10 pm)
Re: [PATCH net-next-2.6 3/3] vmxnet3: Remove incorrect imp ..., David Miller, (Wed Jun 30, 2:10 pm)
Re: [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_se ..., Randy Dunlap, (Fri Jul 2, 9:55 am)
Re: [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_se ..., David Miller, (Fri Jul 2, 10:07 pm)
Re: [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_se ..., Randy Dunlap, (Sat Jul 3, 12:07 pm)
Re: [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_se ..., Ben Hutchings, (Sat Jul 3, 12:21 pm)
[PATCH net-next-2.6] IB/{nes,ipoib}: Pass supported flags ..., Ben Hutchings, (Sat Jul 3, 12:41 pm)
Re: [PATCH net-next-2.6] IB/{nes,ipoib}: Pass supported fl ..., Roland Dreier, (Sat Jul 3, 1:08 pm)
Re: [PATCH net-next-2.6] IB/{nes,ipoib}: Pass supported fl ..., Ben Hutchings, (Sat Jul 3, 1:40 pm)
Re: [PATCH net-next-2.6] IB/{nes,ipoib}: Pass supported fl ..., David Miller, (Sun Jul 4, 11:48 am)
Re: [PATCH net-next-2.6] IB/{nes,ipoib}: Pass supported fl ..., Randy Dunlap, (Tue Jul 6, 9:22 am)